Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #1055 bug: Tone detector + syllable sound bug #1056

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Fixed #1055 bug: Tone detector + syllable sound bug #1056

merged 2 commits into from
Jan 6, 2025

Conversation

wannaphong
Copy link
Member

@wannaphong wannaphong commented Jan 5, 2025 •
edited
Loading

What does this changes

Fixed #1055 bug: Tone detector + syllable sound bug

How this fixes it

Add more rule

Your checklist for this pull request

  • Passed code styles and structures
  • Passed code linting checks and unit test

@pep8speaks
Copy link

pep8speaks commented Jan 5, 2025 •
edited
Loading

Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 93:9: W503 line break before binary operator
Line 94:9: W503 line break before binary operator
Line 95:9: W503 line break before binary operator

Comment last updated at 2025-01-05 13:44:33 UTC

@coveralls
Copy link

coveralls commented Jan 5, 2025 •
edited
Loading

Coverage Status

coverage: 52.753% (+0.03%) from 52.728%
when pulling f3e772e on fixed-1055
into 37f6ba8 on dev.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@bact
Copy link
Member

bact commented Jan 5, 2025

Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

* In the file [`pythainlp/util/syllable.py`](https://github.com/PyThaiNLP/pythainlp/blob/f3e772e0a0816cc7fe27a534cca35ef0ca7a32f7/pythainlp/util/syllable.py):

Line 93:9: W503 line break before binary operator
Line 94:9: W503 line break before binary operator
Line 95:9: W503 line break before binary operator

Comment last updated at 2025-01-05 13:44:33 UTC

We can ignore this PEP8 W503 as the way our code is will soon be considered a best practice

@bact bact added the bug bugs in the library label Jan 5, 2025
@wannaphong wannaphong merged commit 7332984 into dev Jan 6, 2025
40 of 41 checks passed
@bact bact deleted the fixed-1055 branch January 6, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug bugs in the library
Projects
PyThaiNLP
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Tone detector + syllable sound bug
4 participants
@wannaphong @pep8speaks @coveralls @bact