Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opting out of freethreading support #4652

Open
davidhewitt opened this issue Oct 25, 2024 · 0 comments
Open

Opting out of freethreading support #4652

davidhewitt opened this issue Oct 25, 2024 · 0 comments

Comments

@davidhewitt
Copy link
Member

In #4588 we are preparing to let users opt-in to full freethreading for their modules.

Later, in PyO3 0.24 or 0.25 we will make probably make that the default and have an opt-out.

I wonder, what kind of opt-out makes sense? Opting out of freethreading support for a module by not setting the module flag seems unhelpful, if the result is that users can still install that package on the freethreaded build and just get a degraded experience.

It seems to me like a better end result might be that the package in question refuses to install on the freethreaded build at all.

I guess we could do this by having supports_free_threaded = false expand to a compile error when building on the freethreaded build.

cc @ngoldbaum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant