Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Remove superfluous import a statements when there is already import a.b #2285

Open
e-gebes opened this issue Aug 14, 2024 · 0 comments

Comments

@e-gebes
Copy link

e-gebes commented Aug 14, 2024

When there is already import a.b then import a is implicitly executed and a is added as a name. Hence, it does not make sense to have both like:

import logging  # this is superfluous
import logging.handlers

This is sufficient, isort should remove the superfluous import

import logging.handlers

Reference:

https://docs.python.org/3/reference/simple_stmts.html#the-import-statement ("Examples")
https://docs.python.org/3/reference/import.html#the-module-cache

Note: if there is an import alias, only the last name is bound, hence in that case nothing can be removed:

import logging  # not superfluous
import logging.handlers as log_handlers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant