Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrated to a new api and added new exercises #347

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

abadoni5
Copy link
Contributor

@abadoni5 abadoni5 commented Mar 16, 2024

Summary

closes #341 and #214, the tastedive api is now broken. Migrated to TVMaze api and added new exercises for the same. Also added unitests for automatic evaluation. Added e2e test to prevent this.

Checklist

  • Variables, functions and comments are translated to Spanish
  • Functions follow underscore notation
  • Spell check done & typos fixed
  • All python code is PEP8 compliant
  • Test coverage with Playwright implemented; locators are Pyhton code
  • Reviewers assigned (all peers & at least 1 mentor)

Screenshots

Screenshot 2024-03-16 at 6 48 45 PM Screenshot 2024-03-16 at 6 49 00 PM Screenshot 2024-03-16 at 7 10 31 PM

@abadoni5
Copy link
Contributor Author

@NicolasSandoval review requested.

Copy link

1 similar comment
Copy link

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TasteDive API is not working in lecture 45_3
1 participant