Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly builds failing for several months #137

Closed
erogluorhan opened this issue Oct 17, 2024 · 13 comments
Closed

Nightly builds failing for several months #137

erogluorhan opened this issue Oct 17, 2024 · 13 comments
Labels
bug Issues that present a reasonable conviction there is a reproducible bug.

Comments

@erogluorhan
Copy link
Member

What happened:

Dear authors (cc'ing @mgrover1 and @brian-rose as you have the two largest contributions), the nightly builds of this cookbook have been failing for the last several months.

Could you please have a look at it?

Minimal Complete Verifiable Example:

Latest nightly build as of the creation of this issue.

Anything else we need to know?:

If you think it is due to Pythia infrastructure or something else other than the cookbook itself, please let us know.

@erogluorhan erogluorhan added the bug Issues that present a reasonable conviction there is a reproducible bug. label Oct 17, 2024
@brian-rose
Copy link
Member

It's failing upon trying to

import pyart

I was able to reproduce this behavior locally in a freshly created environment. I assume it's because of some package version inconsistencies in the environment. That's as far as I've dug so far.

@brian-rose
Copy link
Member

I also got the same failure in a "plain pyart" environment by doing this:

mamba create --name pyart-test arm_pyart -c conda-forge
conda activate pyart-test
python -c "import pyart"

The import error is coming from xradar (a dependency of pyart), and is related to the recent merging of DataTree into Xarray.

The solved environment has the latest xarray 2024.10.0 and xradar 0.6.5 which are incompatible. Something is going wrong with the conda environment description for pyart. That's probably a solvable problem. But it might be moot.

I see that the xradar folks are close to releasing a version compatible with the latest xarray (openradar/xradar#223) so I think it the best choice for now is to do nothing and allow upstream to catch up.

@mgrover1

@mgrover1
Copy link
Contributor

Yes - there are some compatibility issues we are currently sorting through. We are working on resolving this ASAP, thank you for raising this to our attention

@clyne
Copy link

clyne commented Oct 30, 2024

FWIW there was some discussion at the Pangeo meeting today about compatibility issues with the latest xarray

@kmuehlbauer
Copy link

kmuehlbauer commented Oct 31, 2024

If you are in need of testing: Please pin xradar to 0.7.0 (it will have a pin for xarray <= 2024.9.0).

When xradar is capable of supporting xarray >= 2024.10.0 we'll release xradar 0.8.0 (which should be out next week, Nov 4th/5th latest).

@kmuehlbauer
Copy link

@clyne Could you point me to some resources of that meeting? Interested in the particular issues there. Thanks!

@brian-rose
Copy link
Member

Quick update here, xradar 0.8.0 is now released with compatibility with the latest xarray and datatree. We are still failing on import pyart for now. Looks like there's some progress on pyart compatibility here: ARM-DOE/pyart#1681

@kmuehlbauer
Copy link

@brian-rose Pinning xradar to 0.7.0 and xarray to <=2024.9.0 should get you going until the party issues are sorted out.

@mgrover1
Copy link
Contributor

mgrover1 commented Nov 7, 2024

@kmuehlbauer @brian-rose - I am looking at this today and will be cutting a new release of Py-ART that should solve this problem! Thank you for raising the issue and your patience here.

@erogluorhan
Copy link
Member Author

@mgrover1, looks like the latest nightly build from yesterday still failed but the build issues now seems to be due to a FileNotFound error if you'd like to have a look into it.

@mgrover1
Copy link
Contributor

After a bit of debugging and the merging of #139 , looks like things are building again 👍

@mgrover1
Copy link
Contributor

Looks like the green badge is back! Closing this out; I sincerely apologize for the delay here, and appreciate the team bringing this to our attention, as well as everyone who contributed to the ecosystem updates required to fix things!

@github-project-automation github-project-automation bot moved this from In Progress to Done in Pythia Projects Board Nov 12, 2024
@erogluorhan
Copy link
Member Author

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that present a reasonable conviction there is a reproducible bug.
Projects
Status: Done
Development

No branches or pull requests

5 participants