Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples with secrets not executing #48

Open
mgrover1 opened this issue Apr 5, 2023 · 4 comments
Open

Examples with secrets not executing #48

mgrover1 opened this issue Apr 5, 2023 · 4 comments
Assignees
@mgrover1
Labels
bug Issues that present a reasonable conviction there is a reproducible bug. hackathon Issue highlighted for active hackathon session infrastructure Infrastructure related issue

Comments

@mgrover1
Copy link
Contributor

mgrover1 commented Apr 5, 2023

What happened:
Since the new ARM/ESGF example uses github secrets, we are running into issues passing those credentials to the execution workflow on the binderhub

What you expected to happen:
We should be able to execute notebooks with secrets through the CI system, especially since binderbot explicitly allows this.

Anything else we need to know?:
I opened a PR to resolve this over in ProjectPythia/cookbook-actions#50
@mgrover1 mgrover1 added the bug Issues that present a reasonable conviction there is a reproducible bug. label Apr 5, 2023
@brian-rose brian-rose added the infrastructure Infrastructure related issue label Apr 27, 2023
@brian-rose
Copy link
Member

@mgrover1 is it true that ProjectPythia/cookbook-actions#50 didn't fix this?

We're putting the "high priority" label here, but please close if this is already taken care of.

@mgrover1
Copy link
Contributor Author

mgrover1 commented May 1, 2023

Thanks @ktyle - planning on troubleshooting more tomorrow.

This was referenced May 2, 2023
Merged
Closed
@brian-rose brian-rose mentioned this issue May 15, 2023
Open
@brian-rose brian-rose added the hackathon Issue highlighted for active hackathon session label Jun 12, 2023
@ktyle
Copy link

ktyle commented Jul 24, 2023

@mgrover1 can this be closed now? Or are there still some unresolved issues?

@brian-rose
Copy link
Member

I think there are some remaining unresolved issues with secrets and Pull Requests. I was tracking this work here:
ProjectPythia/cookbook-actions#77

@clyne clyne moved this from Todo to In Progress in Pythia Projects Board Aug 21, 2023
@erogluorhan erogluorhan moved this from In Progress to On Pause in Pythia Projects Board Oct 16, 2023
@erogluorhan erogluorhan moved this from On Pause to In Progress in Pythia Projects Board Nov 20, 2023
@erogluorhan erogluorhan moved this from In Progress to On Pause in Pythia Projects Board May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgrover1 mgrover1

Labels
bug Issues that present a reasonable conviction there is a reproducible bug. hackathon Issue highlighted for active hackathon session infrastructure Infrastructure related issue
Projects
Pythia Projects Board
Status: On Pause
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ktyle @clyne @brian-rose @mgrover1 @erogluorhan