Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPoE Export Issues 3.20.1 #102

Open
blvcksvn opened this issue Jan 3, 2023 · 5 comments
Open

PyPoE Export Issues 3.20.1 #102

blvcksvn opened this issue Jan 3, 2023 · 5 comments

Comments

@blvcksvn
Copy link

blvcksvn commented Jan 3, 2023

  1. Items listed under Quest Rewards having fields being deleted by bot:

Example: Etched Kite Shield

|quest_reward1_item_level = 44
|quest_reward1_rarity_id = rare

Deleted by bot on export.

  1. Microtransaction "Cosmetic_theme" field being deleted by bot:

Example: Delve Core Gloves

|cosmetic_theme = Core 2021

Deleted by bot on export.

  1. Ivory Watchstone and Platinum X Watchstones having "class_id" modified by bot:

Example: Ivory Watchstone
Was changed from
|class_id = AtlasRegionUpgradeItem
to
|class_id = AtlasUpgradeItem
Also includes unique versions. These items should be skipped for next export.

@zao
Copy link
Collaborator

zao commented Jan 11, 2023

Quest Rewards

Went down a false start here looking at item.py exports but it seems like this may be separately sourced via lua.py where the logic for the quest rewards table was removed after the DAT tables were stripped from the game files for several releases:
5635e85

Some of the tables are now back and the logic might be possible to partially reinstate:
https://poedb.tw/us/DataHistory?cn=QuestRewards
https://poedb.tw/us/DataHistory?cn=QuestRewardOffers
https://poedb.tw/us/DataHistory?cn=QuestVendorRewards

Cosmetic Themes

According to comments the field it's leveraging was removed in 3.17, I don't know if it moved into some other place. The labels seem to be in ShopTag.dat64 but I'm not sure if those are connected anywhere.

Old Watchstones

Should be straightforward enough with whatever skipping mechanism we have but I've never added anything to it, needs some testing.

@zao
Copy link
Collaborator

zao commented Jan 11, 2023

The association table for Cosmetic Themes is CurrencyItems which connects BaseItemTypes and ShopTag.

@acbeaumo
Copy link
Collaborator

acbeaumo commented Jan 11, 2023

Cosmetic Theme was removed. It's Cosmetic Type that we care about.

Edit: Looks like you're right, @zao. I didn't see that. Still, it's Cosmetic Type that we care about mostly, and I think that was also removed or changed somehow in the game data from how it was stored previously.

@zao
Copy link
Collaborator

zao commented Jan 11, 2023

Cosmetic Type is also in CurrencyItems as a string CosmeticTypeName.
Do we not care about the theme/series of MTX?

@zao
Copy link
Collaborator

zao commented Jan 11, 2023

I believe I've fixed the Cosmetic Type and Cosmetic Theme fields by taking them from CurrencyItems, will make a PR for that eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants