Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default branch name #539

Open
kevinmcox opened this issue Feb 25, 2022 · 6 comments
Open

Default branch name #539

kevinmcox opened this issue Feb 25, 2022 · 6 comments

Comments

@kevinmcox
Copy link
Member

Would renaming our default branch from master to main break anything for anyone?

https://github.com/github/renaming

@apizz
Copy link
Collaborator

apizz commented Feb 25, 2022

I doubt it and I've thought about doing this for a while, just hadn't done it with a project like this which I cared about and didn't want to screw up 😅

@kevinmcox
Copy link
Member Author

I think the GitHub Action would need to be updated since I believe it is watching the master branch. Unless it is smart enough to follow the rename. @homebysix any thoughts?

@homebysix
Copy link
Collaborator

Submitted PR #540, which should allow the workflows to continue working after changing the branch name.

@homebysix
Copy link
Collaborator

Aside from that, my main concern would be whether the iMazing Profile Editor and ProfileCreator apps are specifically looking for the master branch. If so, you may need to maintain both main and master for a while until the apps are updated.

@kevinmcox
Copy link
Member Author

@homebysix
Copy link
Collaborator

I'm not sure whether that note is applicable to Git remotes or just GitHub web URLs.

I also can't find where the ProfileManifests repo is mentioned in the ProfileCreator code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants