Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the status change if the user who answers is not the requester? #903

Open
marien-probesys opened this issue Jan 9, 2025 · 1 comment
Labels
topic: ticketing All the stuff related to the tickets
Milestone

Comments

@marien-probesys
Copy link
Member

marien-probesys commented Jan 9, 2025

Problem

There are cases where an observer or a user allowed to access all the tickets answers to a "pending" ticket. In this case, the ticket stays in this status. However, as the ticket needs the attention of the assignee, it would make sense to change its status to "in progress".

The same problem happens with the "resolved" status, as one can expect the ticket to be reopened. This case is even worse because the agents could miss the answer and the ticket would be closed few days later.

Solution

For now, we’ll focus on the "resolved" status: when an answer is posted (either by email or in the interface), if the status of the ticket is resolved and the user is not an agent, then change the status to "in_progress" and remove the solution.

Specifications

In App\TicketActivity\LifecycleSubscriber::processAnswer(), move the if status = 'resolved' block outside of the if messageAuthor = requester condition. Also, don't check if the message was sent by email (this is an old condition that is no longer required). However, check if messageAuthor is not agent.

@marien-probesys marien-probesys added topic: ticketing All the stuff related to the tickets type: improvements usability testing We need to perform testing with users to evaluate the features labels Jan 9, 2025
@marien-probesys marien-probesys self-assigned this Jan 16, 2025
@marien-probesys marien-probesys added the ready ✅ You can work on this! label Jan 16, 2025
@marien-probesys marien-probesys removed the usability testing We need to perform testing with users to evaluate the features label Jan 16, 2025
@marien-probesys
Copy link
Member Author

marien-probesys commented Jan 16, 2025

The ticket is now reopened if any user answers to a resolved ticket (v0.14.0). I'm keeping this ticket opened to discuss the "in progress" case for the 0.15.0.

@marien-probesys marien-probesys removed the ready ✅ You can work on this! label Jan 16, 2025
@marien-probesys marien-probesys removed their assignment Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: ticketing All the stuff related to the tickets
Projects
None yet
Development

No branches or pull requests

1 participant