Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute noink not working as expected #97

Open
1 of 8 tasks
LiberQuack opened this issue Jul 16, 2016 · 2 comments
Open
1 of 8 tasks

Attribute noink not working as expected #97

LiberQuack opened this issue Jul 16, 2016 · 2 comments

Comments

@LiberQuack
Copy link

LiberQuack commented Jul 16, 2016

Description

Despiste documentation mention we can use noink attribute to disable ripple effect, The ripple is created and executed on tap

Expected outcome

Toggling paper-toggle-button should not create or execute the ripple effect while noink attribute is present

Actual outcome

When the user toggles the element, the ripple effect is created and executed while noink attribute is present

Live Demo

https://elements.polymer-project.org/elements/paper-toggle-button?view=demo:demo/index.html&active=paper-toggle-button

Steps to reproduce

  1. Put a paper-toggle-button element in the page.
  2. Add noink attribute
  3. Set chrome to simulate touch device
  4. In the browser... toggle the element

Browsers Affected

Tested browsers

  • Chrome
  • Firefox

Not tested

  • Safari 9
  • Safari 8
  • Safari 7
  • Edge
  • IE 11
  • IE 10
@notwaldorf
Copy link
Contributor

I thiiiiink that is not actually the ripple, but the "element is focused" indicator, which should still be visible, for accessibility, despite the element having no ripple.

Otherwise, the noink attribute doesn't work, as expected: http://jsbin.com/quvucu/edit?html,output

@LiberQuack
Copy link
Author

Hmmmm, I think I got the idea... My real concern is that it causes some lag or poor devices... I mean... I ran it on a Motorola G and it went smooth, but running on a Galaxy S4 I realized some lagging on first tap

Is there someway to turn focus indicator off?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants