Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling when disabled #86

Open
kbenjamin opened this issue Mar 6, 2016 · 1 comment
Open

Styling when disabled #86

kbenjamin opened this issue Mar 6, 2016 · 1 comment

Comments

@kbenjamin
Copy link

As it currently stands, there is no way to style paper-toggle-button when it is disabled.

Can you please add additional mixins to support that styling? I'm willing to do it, if you'll accept the pull request.

@bicknellr
Copy link
Contributor

I think we should make the selector paper-toggle-button[disabled] work (like the CSS here) instead of doubling the number of mixins / custom properties. This would mean splitting all the mixin / custom property usages into a pair of selector:not([disabled]) and selector[disabled] rules to prevent backwards incompatibility with users that already expect the disabled state to take precedence over their values. (It looks like this might already be happening in a few places.) Feel free to submit a PR and thanks for bringing this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants