Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chef attributes #33

Open
leonardofl opened this issue Feb 13, 2017 · 0 comments
Open

Chef attributes #33

leonardofl opened this issue Feb 13, 2017 · 0 comments

Comments

@leonardofl
Copy link
Contributor

I think the Chef attributes model is pretty confusing, so maybe I'm talking rubbish, but I would like to propose the following: separate attributes we have to change in different environments in the node.json.

With environment, I mean local, staging and production.

By reading attributes/default.rb it's hard to know which attributes we have really to change before run the recipe on staging or production. Most of them can be left as they are.

So I believe it would be cleaner to place the "changing attributes" on the node.json.

Obs: in local environment, the node.json attributes are declared on the .kitchen.yml file.

So, here it goes the attributes I believe should go to node.json:

  • environment
  • db.root_password
  • db.polignu.password
  • db.poligen.password
  • linux_user
  • server_name

I'm still confused about the authorization attributes group and the nginx.real_ip_from attribute.

Since now we are using the 443 port on the .kitchen.yml, maybe we can forget the ssl_public_port attribute and just use the 443 value wherever it's needed.

What do you think Diego?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant