Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forceGenerateImages and non-existent images #15

Open
Jesus82 opened this issue Dec 1, 2018 · 4 comments
Open

forceGenerateImages and non-existent images #15

Jesus82 opened this issue Dec 1, 2018 · 4 comments
Labels
bug Something isn't working

Comments

@Jesus82
Copy link

Jesus82 commented Dec 1, 2018

Hi, first of all, big thank you for this component, it really brings the best of gulp processing-style into nuxt.

I'm facing an scenario where I npm run generate with forceGenerateImages and some of the "original" images can be missing. If that happens, the generate process stops. Is there any way to let the generate process run even if there are some missing images?

@Barry-Fisher Barry-Fisher added the bug Something isn't working label Feb 7, 2019
@Barry-Fisher
Copy link
Contributor

Hi @Jesus82.

Thank you very much for the compliment. It's good to hear that this module is proving useful!

Do you know if this is still an issue? I haven't tried the test case where source images may be missing.

When I get time I'll check in and see if I can duplicate this.

Thanks,

Barry

@simonhrogers
Copy link

Hi Barry,

I can confirm I have this problem also if I remove some of the source files – say if they are declared in a JSON file somewhere and used by the app.

I get this warning for every size of the first missing image, the the process stops with a ✖ Nuxt Fatal Error:

 ERROR  Command failed: gm convert: Unable to open file (/Users/tempura/Dropbox/websites/the-entente-website/entente-nuxt-ssr/assets/images/batch-1/colophon-foundry-montefiore-type-specimen-2.jpg) [No such file or directory].                                       09:27:10
  
  at ChildProcess.onExit (node_modules/gm/lib/command.js:301:17)
  at ChildProcess.emit (events.js:188:13)
  at ChildProcess.EventEmitter.emit (domain.js:441:20)
  at maybeClose (internal/child_process.js:978:16)
  at Process.ChildProcess._handle.onexit (internal/child_process.js:265:5)

This would be very helpful!

Best,

Simon

@kissa1001
Copy link

Got the same issue! Subscribing

Barry-Fisher pushed a commit that referenced this issue Sep 20, 2019
@Barry-Fisher
Copy link
Contributor

Please try a fix I just added to a new release 1.4.1 and let me know generating images works for you.

I added a check to see whether the source file exists and if it doesn't it skips generating that particular image and displays a warning at the console for each file that may be missing. E.g. Warning: Source file not found at ./content/cat.jpg. Perhaps you referenced this image somewhere and it has since been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants