From 7ef0e6f54d79f16becc3652cad6f22db050b7896 Mon Sep 17 00:00:00 2001 From: Vitalij Ryndin Date: Tue, 5 Dec 2023 15:26:13 +0800 Subject: [PATCH] chore: ignore private properties to d.ts --- packages/cli/mock/locales/strings1.xml | 2 +- packages/cli/package.json | 4 +++- packages/cli/src/utils/files.test.ts | 3 ++- packages/xml-locales/src/utils/xml.ts | 3 +++ packages/xml-locales/src/xml-locales.ts | 6 +++++- pnpm-lock.yaml | 11 ++++++----- 6 files changed, 20 insertions(+), 9 deletions(-) diff --git a/packages/cli/mock/locales/strings1.xml b/packages/cli/mock/locales/strings1.xml index 18e1a15..da03b30 100644 --- a/packages/cli/mock/locales/strings1.xml +++ b/packages/cli/mock/locales/strings1.xml @@ -1,4 +1,4 @@ value1 value2 - + \ No newline at end of file diff --git a/packages/cli/package.json b/packages/cli/package.json index b593084..581682d 100644 --- a/packages/cli/package.json +++ b/packages/cli/package.json @@ -27,8 +27,10 @@ }, "dependencies": { "@inquirer/prompts": "3.3.0", - "@types/yargs": "17.0.32", "xml-locales": "workspace:0.0.4", "yargs": "17.7.2" + }, + "devDependencies": { + "@types/yargs": "17.0.32" } } diff --git a/packages/cli/src/utils/files.test.ts b/packages/cli/src/utils/files.test.ts index 0fe6972..6c9b656 100644 --- a/packages/cli/src/utils/files.test.ts +++ b/packages/cli/src/utils/files.test.ts @@ -67,7 +67,8 @@ describe('writeFile', () => { ` value1 value2 -` + +` ); }); }); diff --git a/packages/xml-locales/src/utils/xml.ts b/packages/xml-locales/src/utils/xml.ts index 3a68d3d..207665d 100644 --- a/packages/xml-locales/src/utils/xml.ts +++ b/packages/xml-locales/src/utils/xml.ts @@ -40,8 +40,11 @@ const defaultXmlOptions: XmlConstructor = { }; export class XmlParser { + /** @internal */ private parser: XMLParser; + /** @internal */ private builder: XMLBuilder; + /** @internal */ private formatter: (xmlString: string) => string; constructor(xmlOptions?: XmlConstructor) { diff --git a/packages/xml-locales/src/xml-locales.ts b/packages/xml-locales/src/xml-locales.ts index 9948110..f70808d 100644 --- a/packages/xml-locales/src/xml-locales.ts +++ b/packages/xml-locales/src/xml-locales.ts @@ -15,9 +15,11 @@ import type { import type { XmlConstructor } from './utils/xml.js'; export class XmlLocales { + /** @internal */ private readonly xmlParser: XmlParser; - + /** @internal */ private xmlOptions?: XmlConstructor; + /** @internal */ private xmlData: XmlJsonData; constructor( @@ -29,6 +31,7 @@ export class XmlLocales { this.parseXml(xmlData); } + /** @internal */ private parseXml(xmlData?: XmlDataTypes): void { if (xmlData instanceof XmlJsonData) { this.xmlData = xmlData; @@ -52,6 +55,7 @@ export class XmlLocales { } } + /** @internal */ private newInstance(): XmlLocales { return new XmlLocales(this.xmlData, this.xmlOptions); } diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index c56f1ce..baf961a 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -47,15 +47,16 @@ importers: '@inquirer/prompts': specifier: 3.3.0 version: 3.3.0 - '@types/yargs': - specifier: 17.0.32 - version: 17.0.32 xml-locales: specifier: workspace:0.0.4 version: link:../xml-locales yargs: specifier: 17.7.2 version: 17.7.2 + devDependencies: + '@types/yargs': + specifier: 17.0.32 + version: 17.0.32 packages/xml-locales: dependencies: @@ -1267,13 +1268,13 @@ packages: /@types/yargs-parser@21.0.3: resolution: {integrity: sha512-I4q9QU9MQv4oEOz4tAHJtNz1cwuLxn2F3xcc2iV5WdqLPpUnj30aUuxt1mAxYTG+oe8CZMV/+6rU4S4gRDzqtQ==} - dev: false + dev: true /@types/yargs@17.0.32: resolution: {integrity: sha512-xQ67Yc/laOG5uMfX/093MRlGGCIBzZMarVa+gfNKJxWAIgykYpVGkBdbqEzGDDfCrVUj6Hiff4mTZ5BA6TmAog==} dependencies: '@types/yargs-parser': 21.0.3 - dev: false + dev: true /@vitest/coverage-v8@0.34.6(vitest@0.34.6): resolution: {integrity: sha512-fivy/OK2d/EsJFoEoxHFEnNGTg+MmdZBAVK9Ka4qhXR2K3J0DS08vcGVwzDtXSuUMabLv4KtPcpSKkcMXFDViw==}