-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time part of custom prompt showing incorrectly on next line on startup #90
Comments
Hm. I do have a right prompt for Fish that show the time - and that seems to work. If you give to detailed steps to reproduce your problem, I can look into it. |
I notice DomTerm prints the size of the terminal briefly on startup and then it disappears. The terminal size eg. 149x32... appears where the time would be and it looks like it pushes the time down, then it disappears. Maybe the terminal size could be shown briefly in the window title instead? The theme I am using is https://github.com/Bash-it/bash-it/blob/master/themes/brainy/brainy.theme.bash which I installed through bash-it (which is similar to oh-my-zsh and oh-my-fish). My settings.ini for DomTerm is:
The end of my .bashrc looks like this (before this bash-it automatically added some stuff including an env var with the name of the theme - brainy):
|
I got brainy to work - similar to your screenshot - but the first line does show the time on the right similar to other lines. "I notice DomTerm prints the size of the terminal briefly on startup and then it disappears. The terminal size eg. 149x32... appears where the time would be and it looks like it pushes the time down, then it disappears. Maybe the terminal size could be shown briefly in the window title instead?" That shouldn't be an issue - the popup notification is in a separate "overlay" - it does not appear in the terminal "buffer". If it "pushes the time down", that could be a browser bug What browser are you using? I tested both Electron and Firefox. Are you using the latest DomTerm from git? |
@PerBothner I am using QTDomTerm - have you tried Brainy with that? BTW, I had assumed QTDomTerm would be faster than the Electron based version - is that right or is there no difference? |
I do see some issues with the theme when the prompt doesn't fit on a single line. And it does seem to be mis-behaving worse/differently when using Qt. I'm somewhat confused because I'm using Qt 5.15.2 (as installed on Fedora 33), but the "userAgent" reports I could probably implement a work-round, but it doesn't seem a high priority - I'm inclined to wait to see if Qt6 fixes it. The command I doubt there would be a noticeable speed difference between Qt or Electron or I'm experimenting with a tab/sub-window library using Qt. If that works out, at that point |
Thanks for looking into it. domterm status gives:
The Chrome version I get looks much more recent than yours. domterm --chrome has the same problem for me. |
After starting
(The latest non-beta Electron is 11.2, which has Chromium 87.) This is somewhat strange, as Have you tried other front-ends? |
I don't have electron set up right now but if I do domterm --chrome and domterm--chrome-app, I get:
|
Is the problem also present on Chrome? What about Firefox? (You probably don't want to use a regular browser for your normal terminal, but |
Yes, the problem is also present on Chrome (87.0.4280.141) using --chrome-app. I've not tried electron or webview so far. |
I have a custom prompt with the time on the right hand side. When DomTerm first loads, the time incorrectly shows on the next line, but subsequently is ok. See the following screenshot:
The text was updated successfully, but these errors were encountered: