[Feat] 2x2 가장 가까운 버스정류장 보여주는 위젯 기능 #253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
isakatty
commented
Apr 23, 2024
Comment on lines
+18
to
+21
| private let useCase = NearByStopUseCase( | ||
| stationListRepository: DefaultStationListRepository(), | ||
| locationService: DefaultLocationService() | ||
| ) |
There was a problem hiding this comment.
@yuhaeun-la
보통 DIContainer를 통해서 repository랑 service를 넣어주는 방식으로 그동안 작업해왔는데, 이렇게 직접적으로 넣어주는 것에 대해서 어떻게 생각하시나요? 이 방식이 잘못된거라면, @injected ~ usecase ~ 하고, DIContainer에서 register 시켜주는 것으로 변경해볼게요 !
There was a problem hiding this comment.
저희가 클린아키텍쳐를 택하고 있기 때문에 이렇게 직접적으로 연결해주는것보다 의존성을 주입해주는 방식을 사용하는게 더 좋아보입니다 !
yuhaeun-la
reviewed
Apr 23, 2024
| static func nanumHeavySU(size: CGFloat) -> Font { | ||
| Nanum.heavy.swiftUIFont(size: size) | ||
| } | ||
| } |
There was a problem hiding this comment.
앗 저도 Extension Font +넣었어요 ~ 다음에 합쳐요
| func getTimeline( | ||
| in context: Context, | ||
| completion: @escaping (Timeline<NearByStopEntry>) -> Void | ||
| ) { | ||
| // 이때는 위젯에 잘 나옴 | ||
| let timeline = Timeline( | ||
| entries: [NearByStopEntry.mock], | ||
| policy: .never |
There was a problem hiding this comment.
이 위젯의 경우엔 policy 값에 .never보단 전에 상의한 .after() 형태로 가는게 좋을 것 같습니다 !
Comment on lines
+18
to
+21
| private let useCase = NearByStopUseCase( | ||
| stationListRepository: DefaultStationListRepository(), | ||
| locationService: DefaultLocationService() | ||
| ) |
There was a problem hiding this comment.
저희가 클린아키텍쳐를 택하고 있기 때문에 이렇게 직접적으로 연결해주는것보다 의존성을 주입해주는 방식을 사용하는게 더 좋아보입니다 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업내용
위젯 뷰 작업
현 데브랑 맞춰가기 위해 위젯 1차 PR 입니다.
리뷰요청
관련 이슈
close #239