Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to use latest prom-client #64

Open
fksimon opened this issue Feb 16, 2021 · 2 comments
Open

Update to use latest prom-client #64

fksimon opened this issue Feb 16, 2021 · 2 comments

Comments

@fksimon
Copy link

fksimon commented Feb 16, 2021

The latest prom-client 13.0.x does not work due to some api changes. The new prom-client has some substantial enhancements so would be nice to be able to use.

https://github.com/siimon/prom-client/releases

Main impacting change:
metrics server has a line like res.send(register.metrics()), you
should change it to res.send(await register.metrics()).
@yorch
Copy link
Contributor

yorch commented Feb 16, 2021

Created a PR #65

@yorch yorch mentioned this issue Feb 16, 2021
Merged
@robross0606
Copy link

prom-client v14 has now been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yorch @robross0606 @fksimon