Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A .remove-underline helper class for anchors? #334

Open
stepandersen opened this issue Apr 23, 2019 · 2 comments
Open

A .remove-underline helper class for anchors? #334

stepandersen opened this issue Apr 23, 2019 · 2 comments
Labels
question Further information is requested

Comments

@stepandersen
Copy link

stepandersen commented Apr 23, 2019

We have this rule, which we discussed, implemented and knew could be problematic as a general rule:
a { color: #266c9a; border-bottom: 2px solid #266c9a; }

It is problematic for everything except as links in a block of text. My use case is links in tables or as headings.
image

image

image

It is easy enough to write a custom rule to remove this underline, but is it a good idea to include a .remove-underline class to anchors? (It should get a better name of course)

@stepandersen stepandersen added the question Further information is requested label Apr 23, 2019
@Akswii
Copy link
Contributor

Akswii commented May 20, 2019

We need more than just color to differentiate a link from block-text so we are skeptical to add a helper-class to remove underline. Is this an aesthetic issue? If yes then we should make new ways to present links in tables and other components.

@stepandersen
Copy link
Author

Yes, it's aesthetic. Any solution to remove the undelines is fine by me. I don't believe that my example Charlie Checkoutcustomer under Customer will be a component though.

Another approach that might be okay is to specify underline for block text links: p a { border-bottom: 2px solid #266c9a; }.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants