Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Software Upgrade Doesn't Allow for Larger Major Version Change #553

Open
GitBacon9000 opened this issue Feb 29, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@GitBacon9000
Copy link

Describe the bug

When trying to upgrade fleet from 10.1 -> 11.1, panos module returns an error saying the upgrade path is invalid.

Expected behavior

PAN documentation and the firewalls themselves allow for this upgrade path, but the ansible module has hardcoded this option out.

Current behavior

Ansible module error:
msg: 'Version Sequence is invalid: 10.1-> 11.1.0'

Possible solution

Take out the section of code surrounding any output given from the firewalls, or in the

def is_valid_sequence(current, target):
# Patch version change (major and minor versions match)
if (current.major == target.major) and (current.minor == target.minor):
return True

# Upgrade minor version (9.0.0 -> 9.1.0)
elif (current.major == target.major) and (current.minor + 1 == target.minor):
    return True

# Upgrade major version (9.1.0 -> 10.0.0)
elif (current.major + 1 == target.major) and (target.minor == 0):
    return True

# Downgrade minor version (9.1.0 -> 9.0.0)
elif (current.major == target.major) and (current.minor - 1 == target.minor):
    return True

# Downgrade major version (10.0.3 -> 9.1.6)
elif current.major - 1 == target.major:
    return True

else:
    return False

allow for larger major version upgrades.

Steps to reproduce

Try and run an upgrade from the versions given.

  • Collection: 2.19.3
@GitBacon9000 GitBacon9000 added the bug Something isn't working label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant