Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figma: The Event Dashboard Screen Violates the Figma Style Guide #3431

Open
palisadoes opened this issue Jan 26, 2025 · 3 comments
Open

Figma: The Event Dashboard Screen Violates the Figma Style Guide #3431

palisadoes opened this issue Jan 26, 2025 · 3 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers ui/ux issue related and being worked with the figma file of the Admin UI unapproved

Comments

@palisadoes
Copy link
Contributor

Post a video of your work in the PR

Describe the bug

  1. Event dashboard screen does not conform to our Figma style guide

To Reproduce
Steps to reproduce the behavior:

  1. Login to the app
  2. Select an organization
  3. Go to the events page
  4. Select an event
  5. Go to the event dashboard

The solution must work for

  1. Users
  2. Admins
  3. SuperAdmins

Tests:

  1. Tests must be written to ensure this does not happen again

Other

  1. The foundational work for this was completed in this PR:
  2. When in doubt about colors, take cues from other similar elements in this file and the PR mentioned in the issue.
    1. https://www.figma.com/design/dmKt00m9GVSeA1nebnkxql/Untitled?node-id=0-1&node-type=canvas&t=TPzfh1DE9IxjzsEe-0
  3. The desired single CSS file is:
    1. src/style/app.module.css
      1. Convert all code files to use this file.
      2. Delete all CSS files in this code path and below mentioned in the title. The src/style/app.module.css file must be the only source of CSS
  4. Use no CSS in:
    1. assets/css/app.css
  5. Use variable names that describe the function of the color and not the color itself. This will help with future attempts to having Dark Mode.
    1. For example --search-button-bg is much better than --light-blue
    2. NoMongo: Fix Stylesheet in Anticipation of Dark Mode #3296
  6. When refactoring modals, please refer to this PR that has created a standardized design patter for them.
    1. Updating to NEW COLOR SCHEME #2984
  7. Remove all references to HTML color codes in the files you edit except in src/style/app.module.css
  8. Buttons, and dropdowns must only have shadows when there is a mouse hover. Their color must not change
  9. Search boxes must only have shadows when selected

Actual behavior

  • See screen shots

Screenshots

  1. Example
    Image
  2. Example
    Image
  3. Example
    Image

Additional details

  • N/A

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@palisadoes palisadoes added the bug Something isn't working label Jan 26, 2025
@github-actions github-actions bot added ui/ux issue related and being worked with the figma file of the Admin UI unapproved good first issue Good for newcomers labels Jan 26, 2025
@Bittukr7479
Copy link

Hiii @palisadoes I want to work on this issue, please assign me.

@sushen123
Copy link

Hello @palisadoes, i haven’t been assigned any issues yet. could you please assign me this one?

@abbi4code
Copy link
Contributor

May i work on this issue Sir, i have worked talawa-admin ui-ux by refactoring css before also ? @palisadoes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers ui/ux issue related and being worked with the figma file of the Admin UI unapproved
Projects
Status: Backlog
Development

No branches or pull requests

4 participants