Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting fails with schema.graphql #3409

Open
palisadoes opened this issue Jan 24, 2025 · 2 comments
Open

Linting fails with schema.graphql #3409

palisadoes opened this issue Jan 24, 2025 · 2 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Jan 24, 2025

Describe the bug

  1. Linting
    1. There will be extensive edits to schema.graphql as we do more work migrating to the develop-postgres branch
    2. Our current npx eslint <filename> command fails in our GitHub Actions if schema.graphql is included.
    3. Eslint needs to handle the schema.graphql file. This is greatly preferred to excluding the file from linting
    4. This package, or something similar needs to be considered
    5. The npx eslint CLI command should ideally not be altered. If it needs to be then all references to it in documentation, our GitHub actions and code need to be updated
  2. Prettier
    1. We need to add *.graphql files to these prettier commands:
    2. npm format:fix
    3. npm format:check

To Reproduce

  • See failing PR workflow below

Expected behavior

  • Correct linting testing

Actual behavior

  • See above

Screenshots

  1. https://github.com/PalisadoesFoundation/talawa-admin/actions/runs/12944016576/job/36117459224?pr=3400
    Image

Additional details

  • N/A

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@palisadoes palisadoes added the bug Something isn't working label Jan 24, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation unapproved labels Jan 24, 2025
@yugal07
Copy link

yugal07 commented Jan 24, 2025

I would like to take on this issue @palisadoes

@Bittukr7479
Copy link

Hey @palisadoes, I want to work on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants