Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hard-coded messages with slot-based customization #37

Closed
tomalec opened this issue Nov 8, 2016 · 4 comments
Closed

Replace hard-coded messages with slot-based customization #37

tomalec opened this issue Nov 8, 2016 · 4 comments

Comments

@tomalec
Copy link
Member

tomalec commented Nov 8, 2016

Currently, we have hard-coded texts, and HTML structure for presenting messages at https://github.com/PuppetJs/puppet-polymer-client/blob/gh-pages/puppet-client.html#L72

Due to i18n, a11y, customization, theming, cheeper maintenance, etc. those should be customizable.

In my opinion the best way to do so is to use <slot>, we can provide fallback content inside, but tu CE consumer could simply write his/her own:

<puppet-client>
   <div slot="reconnecting-now" class="my-custom-styles">Łączę ponownie</div>
</puppet-client>

So we will no longer have to bother about how to show the message for the mobile, in different language, in different context, etc.

//cc @warpech @mnosek

@warpech warpech added this to the Palindrom nice-to-have features milestone Apr 7, 2018
@alshakero
Copy link
Collaborator

Do you think we should still do this for palindrom-error-catcher?

@tomalec
Copy link
Member Author

tomalec commented May 25, 2018

I think it could be useful. But not with such priority.

@warpech
Copy link
Contributor

warpech commented May 28, 2018

I agree with @tomalec, I will move it to some other milestone.

@warpech
Copy link
Contributor

warpech commented May 28, 2018

Moved to Palindrom/palindrom-error-catcher#2

@warpech warpech closed this as completed May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants