We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently, we have hard-coded texts, and HTML structure for presenting messages at https://github.com/PuppetJs/puppet-polymer-client/blob/gh-pages/puppet-client.html#L72
Due to i18n, a11y, customization, theming, cheeper maintenance, etc. those should be customizable.
In my opinion the best way to do so is to use <slot>, we can provide fallback content inside, but tu CE consumer could simply write his/her own:
<slot>
<puppet-client> <div slot="reconnecting-now" class="my-custom-styles">Łączę ponownie</div> </puppet-client>
So we will no longer have to bother about how to show the message for the mobile, in different language, in different context, etc.
//cc @warpech @mnosek
The text was updated successfully, but these errors were encountered:
Do you think we should still do this for palindrom-error-catcher?
palindrom-error-catcher
Sorry, something went wrong.
I think it could be useful. But not with such priority.
I agree with @tomalec, I will move it to some other milestone.
Moved to Palindrom/palindrom-error-catcher#2
No branches or pull requests
Currently, we have hard-coded texts, and HTML structure for presenting messages at https://github.com/PuppetJs/puppet-polymer-client/blob/gh-pages/puppet-client.html#L72
Due to i18n, a11y, customization, theming, cheeper maintenance, etc. those should be customizable.
In my opinion the best way to do so is to use
<slot>
, we can provide fallback content inside, but tu CE consumer could simply write his/her own:So we will no longer have to bother about how to show the message for the mobile, in different language, in different context, etc.
//cc @warpech @mnosek
The text was updated successfully, but these errors were encountered: