Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid Go Module Name #891

Open
iwahbe opened this issue Jun 20, 2024 · 0 comments
Open

Invalid Go Module Name #891

iwahbe opened this issue Jun 20, 2024 · 0 comments

Comments

@iwahbe
Copy link
Contributor

iwahbe commented Jun 20, 2024

Go's module documentation suggests that module paths should be of the form

github.com/PagerDuty/terraform-provider-pagerduty/v3
^          ^         ^                           ^
VCS URL    ORG       REPO                        VERSION

Currently, it is

module github.com/PagerDuty/terraform-provider-pagerduty

Expected behavior

The module name (in go.mod) is github.com/PagerDuty/terraform-provider-pagerduty/v3

Additional context

I work at Pulumi and maintain pulumi-pagerduty (which is based off of terraform-provider-pagerduty) for shared customers. It would make our lives easier if you used Go's convention for module paths.

If your willing to take it, I'd be happy to open a PR implementing this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant