Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve detection if "--detach" should be set #272

Closed
aliakseix opened this issue Apr 4, 2024 · 2 comments
Closed

Improve detection if "--detach" should be set #272

aliakseix opened this issue Apr 4, 2024 · 2 comments
Labels
good first issue help wanted

Comments

@aliakseix
Copy link

Improve function "shouldUseDefaultNonInteractiveFlag"

Currently it only checks for --abort-on-container-exit and --no-start, but should also check for --attach, --attach-dependencies, and --exit-code-from, since all of these are incompatible with --detach.
@AlexZeitler
Copy link
Contributor

@aliakseix Thanks for pointing this out.

Would sending a PR be an option for you?

@aliakseix
Copy link
Author

#273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlexZeitler @aliakseix