Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: ERC721Royalty extension #358

Open
1 task done
bidzyyys opened this issue Oct 17, 2024 · 3 comments · May be fixed by #508
Open
1 task done

[Feature]: ERC721Royalty extension #358

bidzyyys opened this issue Oct 17, 2024 · 3 comments · May be fixed by #508
Assignees
Labels
effort: medium Default level of effort. good first issue Good for newcomers. priority: 0 Nice-to-have. Willing to ship without this. type: feature New feature request.

Comments

@bidzyyys
Copy link
Collaborator

What is the feature you would like to see?

Add ERC721Royalty extension (solidity).

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
@bidzyyys bidzyyys added priority: 0 Nice-to-have. Willing to ship without this. type: feature New feature request. good first issue Good for newcomers. effort: medium Default level of effort. labels Oct 17, 2024
@18aaddy
Copy link

18aaddy commented Jan 22, 2025

@bidzyyys I would like to work on this issue

@0xNeshi
Copy link
Collaborator

0xNeshi commented Jan 22, 2025

@18aaddy I've assigned this issue to you. Thanks for your interest in contributing! Please let me know if you have any questions.

@18aaddy 18aaddy linked a pull request Jan 23, 2025 that will close this issue
3 tasks
@0xNeshi
Copy link
Collaborator

0xNeshi commented Jan 23, 2025

@bidzyyys @qalisander in Solidity, this extension is implemented under contracts/token/common/* directory, because it supports both ERC-721 and ERC-1155 tokens. They have only implemented ERC721Royalty for now.
Should we organize our contract in a similar manner? We could then add Erc1155Royalty to the roadmap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: medium Default level of effort. good first issue Good for newcomers. priority: 0 Nice-to-have. Willing to ship without this. type: feature New feature request.
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

3 participants