Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pallet grouping macros #1

Open
wants to merge 51 commits into
base: main
Choose a base branch
from
Open

Pallet grouping macros #1

wants to merge 51 commits into from

Conversation

@4meta5 4meta5 self-assigned this Aug 27, 2024
src/system.rs Outdated Show resolved Hide resolved
@4meta5 4meta5 changed the title System Wrapper Macro Pallet grouping macros Sep 30, 2024
@4meta5

This comment was marked as resolved.

@4meta5

This comment was marked as resolved.

src/system.rs Show resolved Hide resolved
@KitHat
Copy link
Member

KitHat commented Oct 21, 2024

@4meta5
I have looked through the groupings and haven't seen pallet_asset_manager in neither of abstractions.

  • We need it in both of our templates (Generic will need it with introduction of Snowbridge support)
  • It will affect the XCM benchmarking -- we need to register assets in AssetManager, and this benchmark should be generated by our macro.
    Could you please add it?

@4meta5
Copy link
Collaborator Author

4meta5 commented Oct 21, 2024

haven't seen pallet_asset_manager

yes because it has not been configured in the generic template yet, will open an issue for this but we should configure them in both templates before adding it to the macros

@ozgunozerk
Copy link
Collaborator

yes because it has not been configured in the generic template yet, will open an issue for this but we should configure them in both templates before adding it to the macros

I configured it due to it was necessary also for snowbridge integration. If it is not there, it is probably on one of my branches, will push soon

@4meta5
Copy link
Collaborator Author

4meta5 commented Oct 21, 2024

I configured it due to it was necessary also for snowbridge integration. If it is not there, it is probably on one of my branches, will push soon

Ok assigned you the new issue OpenZeppelin/polkadot-runtime-templates#340 and will add it pallet wrappers once it gets into main

@ozgunozerk
Copy link
Collaborator

Ok I found it, however it is intertwined with orml_xtokens config. It's late for me, so I can tackle that tomorrow.

If you do not want to wait, the branch is ozgun-xtokens-on-generic.

Let me know if you will extract it yourself or you are ok with waiting for tomorrow @4meta5

@4meta5
Copy link
Collaborator Author

4meta5 commented Oct 21, 2024

No need to extract it -- we can merge it all as it is on your branch first and then add it to the templates after the code is merged into templates/main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In Development
Development

Successfully merging this pull request may close these issues.

Governance grouping EVM grouping Asset grouping Consensus grouping System grouping
3 participants