Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark transpiled contract as abstract if an internal initializer was added. #151

Open
Amxx opened this issue Apr 8, 2024 · 1 comment
Open

Mark transpiled contract as abstract if an internal initializer was added. #151

Amxx opened this issue Apr 8, 2024 · 1 comment

Comments

@Amxx
Copy link
Contributor

Amxx commented Apr 8, 2024

When a non abstract contract has a constructor, and that constructor is "replaced" by an internal initializer in the transpiled version, then the transpiled version should not be deployable without the initializer being somehow exposed. Therefore, transpiled that have an internal initializer should be marked as abstract.
@Amxx
Copy link
Contributor Author

Amxx commented Apr 8, 2024

see OpenZeppelin/openzeppelin-contracts#5002

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Amxx