Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low level call library #5013

Open
Tracked by #5249
Amxx opened this issue Apr 10, 2024 · 3 comments · May be fixed by #5094 or #5091
Open
Tracked by #5249

Low level call library #5013

Amxx opened this issue Apr 10, 2024 · 3 comments · May be fixed by #5094 or #5091
Labels
contracts Smart contract code.
Milestone

Comments

@Amxx
Copy link
Collaborator

Amxx commented Apr 10, 2024

🧐 Motivation
this library provides a solidity level interface to execute calls/staticcalls/delegate call without automatically dupping all the return data to memory. This makes it return-bomb safe.

We should build a similar library an use it in places such as the Forwarder.

@Amxx Amxx added the contracts Smart contract code. label Apr 10, 2024
@Amxx Amxx added this to the 5.1 milestone Apr 10, 2024
@ernestognw
Copy link
Member

@cairoeth brought up the idea of whether to add this functions as part of the Address. I see it could benefit discoverability since it would be easier for users already depending on this library to find out they have a version that ignores returndata available.

I think it's a good idea to consider but perhaps Address is already a weird name for developers looking for ways to perform variants of EVM calls.

@Amxx
Copy link
Collaborator Author

Amxx commented Jun 2, 2024

@Amxx
Copy link
Collaborator Author

Amxx commented Jun 2, 2024

As mentionned on slack, we should focus on avoiding any possible mistake between the current functions in Address.sol, and the "unsafe" ones proposed here. That can be using a separate library (my preference right now), or through proper naming.

We have to make sure mistakes are as unlkikelly to happen as possible.

@Amxx Amxx linked a pull request Jun 19, 2024 that will close this issue
3 tasks
@ernestognw ernestognw linked a pull request Jun 20, 2024 that will close this issue
3 tasks
@ernestognw ernestognw modified the milestones: 5.1, 5.2 Oct 3, 2024
@cairoeth cairoeth modified the milestones: 5.2, 5.3 Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contracts Smart contract code.
Projects
None yet
3 participants