Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] spp_change_request_create_farm: Create Module #699

Open
wants to merge 8 commits into
base: 17.0
Choose a base branch
from
Open

[ADD] spp_change_request_create_farm: Create Module #699

wants to merge 8 commits into from

Conversation

emjay0921
Copy link
Contributor

@emjay0921 emjay0921 commented Jan 2, 2025 •
edited
Loading

Why is this change needed?

To add creation change requests for group and farms which includes all fields for group and individuals.

How was the change implemented?

Added 2 modules, one for CR Create Group and one for CR Create Farm

New unit tests

None

Unit tests executed by the author

None

How to test manually

  • Install or Update spp_change_request_create_group or spp_change_request_create_farm on respective instance. (First one is for SPMIS Instance and other is for Farmer Instance)
  • Create a Change Request for the installed Change Request.
  • Go through with it and apply.

Related links

#681

@emjay0921 emjay0921 linked an issue Jan 2, 2025 that may be closed by this pull request
Create CR type create-group #681
Open
3 tasks
@emjay0921 emjay0921 marked this pull request as ready for review January 6, 2025 01:28
@codecov Codecov
Copy link

codecov bot commented Jan 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 52.06186% with 93 lines in your changes missing coverage. Please review.

Project coverage is 75.92%. Comparing base (016408b) to head (393a335).
Report is 56 commits behind head on 17.0.

Files with missing lines Patch % Lines
...t_create_farm/models/change_request_create_farm.py 50.70% 69 Missing and 1 partial ⚠️
...hange_request_create_farm/models/change_request.py 26.66% 22 Missing ⚠️
.../change_request_create_farm_validation_sequence.py 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             17.0     #699      +/-   ##
==========================================
- Coverage   76.26%   75.92%   -0.34%     
==========================================
  Files         687      693       +6     
  Lines       17777    17993     +216     
  Branches     2205     2241      +36     
==========================================
+ Hits        13558    13662     +104     
- Misses       3772     3880     +108     
- Partials      447      451       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
40.2% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@emjay0921 emjay0921 changed the title 681 create cr type create group [ADD] spp_change_request_create_farm: Create Module Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reichie020212 reichie020212 reichie020212 approved these changes

@gonzalesedwin1123 gonzalesedwin1123 Awaiting requested review from gonzalesedwin1123

@jeremi jeremi Awaiting requested review from jeremi

Assignees

@emjay0921 emjay0921

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create CR type create-group
2 participants
@emjay0921 @reichie020212