From 2272fe9fda917dd68e6ad43e1275dba0aae94c6c Mon Sep 17 00:00:00 2001
From: Maximilien Noal <noal.maximilien@gmail.com>
Date: Sat, 9 Nov 2024 11:32:16 +0100
Subject: [PATCH] chore: Common .csproj lines moved in Build.props

Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
---
 src/Bufdio.Spice86/Bufdio.Spice86.csproj   |  3 ---
 src/Directory.Build.props                  | 29 +++++-----------------
 src/Spice86.Core/Spice86.Core.csproj       |  4 ---
 src/Spice86.Logging/Spice86.Logging.csproj |  6 -----
 src/Spice86.Shared/Spice86.Shared.csproj   |  6 -----
 src/Spice86/Spice86.csproj                 |  4 ---
 6 files changed, 6 insertions(+), 46 deletions(-)

diff --git a/src/Bufdio.Spice86/Bufdio.Spice86.csproj b/src/Bufdio.Spice86/Bufdio.Spice86.csproj
index 26a540e2e..7d482ffed 100644
--- a/src/Bufdio.Spice86/Bufdio.Spice86.csproj
+++ b/src/Bufdio.Spice86/Bufdio.Spice86.csproj
@@ -5,9 +5,6 @@
 	<RootNamespace>Bufdio.Spice86</RootNamespace>
 	<Copyright>Luthfi Tri Atmaja</Copyright>
 	<Description>Only for Spice86 usage. A cross platform audio playback library for .NET based on PortAudio, forked from the original Bufdio by Luthfi Tri Atmaja.</Description>
-	<TargetFramework>net8.0</TargetFramework>
-	<Nullable>enable</Nullable>
-	<WarningsAsErrors>nullable</WarningsAsErrors>
   </PropertyGroup>
   <!-- Properties geared towards NuGet -->
 	<PropertyGroup>
diff --git a/src/Directory.Build.props b/src/Directory.Build.props
index 125690c40..be2026848 100644
--- a/src/Directory.Build.props
+++ b/src/Directory.Build.props
@@ -1,25 +1,8 @@
 <Project>
-	<ItemGroup>
-		<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All" />
-		<PackageReference Include="DotNet.ReproducibleBuilds" Version="1.2.25">
-			<PrivateAssets>all</PrivateAssets>
-			<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-		</PackageReference>
-		<PackageReference Include="ErrorProne.NET.CoreAnalyzers" Version="0.1.2">
-			<PrivateAssets>all</PrivateAssets>
-			<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-		</PackageReference>
-		<PackageReference Include="Roslynator.Analyzers" Version="4.12.9">
-			<PrivateAssets>all</PrivateAssets>
-			<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-		</PackageReference>
-		<PackageReference Include="Roslynator.CodeAnalysis.Analyzers" Version="4.12.9">
-			<PrivateAssets>all</PrivateAssets>
-			<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-		</PackageReference>
-		<PackageReference Include="SerilogAnalyzer" Version="0.15.0">
-			<PrivateAssets>all</PrivateAssets>
-			<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-		</PackageReference>
-	</ItemGroup>
+	<PropertyGroup>
+		<TargetFramework>net8.0</TargetFramework>
+		<ImplicitUsings>enable</ImplicitUsings>
+		<Nullable>enable</Nullable>
+		<WarningsAsErrors>nullable</WarningsAsErrors>
+	</PropertyGroup>
 </Project>
\ No newline at end of file
diff --git a/src/Spice86.Core/Spice86.Core.csproj b/src/Spice86.Core/Spice86.Core.csproj
index cc3592a64..092edd251 100644
--- a/src/Spice86.Core/Spice86.Core.csproj
+++ b/src/Spice86.Core/Spice86.Core.csproj
@@ -1,10 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
 	<PropertyGroup>
-		<TargetFramework>net8.0</TargetFramework>
-		<ImplicitUsings>enable</ImplicitUsings>
-		<Nullable>enable</Nullable>
-		<WarningsAsErrors>nullable</WarningsAsErrors>
 		<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
 		<NoWarn>1591;1572;1573;1570;1587;1574</NoWarn>
 	</PropertyGroup>
diff --git a/src/Spice86.Logging/Spice86.Logging.csproj b/src/Spice86.Logging/Spice86.Logging.csproj
index 8e0362634..83285c43b 100644
--- a/src/Spice86.Logging/Spice86.Logging.csproj
+++ b/src/Spice86.Logging/Spice86.Logging.csproj
@@ -1,10 +1,4 @@
 <Project Sdk="Microsoft.NET.Sdk">
-  <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
-    <ImplicitUsings>enable</ImplicitUsings>
-    <Nullable>enable</Nullable>
-    <WarningsAsErrors>Nullable</WarningsAsErrors>
-  </PropertyGroup>
   <!-- Properties geared towards NuGet -->
   <PropertyGroup>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
diff --git a/src/Spice86.Shared/Spice86.Shared.csproj b/src/Spice86.Shared/Spice86.Shared.csproj
index e4be0bc3a..7e5e6e5c7 100644
--- a/src/Spice86.Shared/Spice86.Shared.csproj
+++ b/src/Spice86.Shared/Spice86.Shared.csproj
@@ -1,11 +1,5 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
-	<PropertyGroup>
-		<TargetFramework>net8.0</TargetFramework>
-		<ImplicitUsings>enable</ImplicitUsings>
-		<Nullable>enable</Nullable>
-		<WarningsAsErrors>Nullable</WarningsAsErrors>
-	</PropertyGroup>
 	<!-- Properties geared towards NuGet -->
 	<PropertyGroup>
 		<GenerateDocumentationFile>true</GenerateDocumentationFile>
diff --git a/src/Spice86/Spice86.csproj b/src/Spice86/Spice86.csproj
index 55fccbd2a..4f4b12a09 100644
--- a/src/Spice86/Spice86.csproj
+++ b/src/Spice86/Spice86.csproj
@@ -2,10 +2,6 @@
 
     <PropertyGroup>
         <OutputType>Exe</OutputType>
-        <TargetFramework>net8.0</TargetFramework>
-        <Nullable>enable</Nullable>
-        <WarningsAsErrors>nullable</WarningsAsErrors>
-        <ImplicitUsings>enable</ImplicitUsings>
         <EnablePackageValidation>true</EnablePackageValidation>
         <AllowUnsafeBlocks>True</AllowUnsafeBlocks>
         <NoWarn>1591;1572;1573;1570;1587;1574</NoWarn>