Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Rust error handling #7

Open
tholop opened this issue Jan 7, 2021 · 2 comments
Open

Improve Rust error handling #7

tholop opened this issue Jan 7, 2021 · 2 comments
Assignees
@dimasquest
Labels
Good first issue 🎓 Perfect for beginners, welcome to OpenMined! Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor

Comments

@tholop
Copy link
Member

tholop commented Jan 7, 2021

Handle errors in the Rust code instead of using assert and assert_eq macros.
@tholop tholop added Good first issue 🎓 Perfect for beginners, welcome to OpenMined! Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor labels Jan 7, 2021
@dimasquest
Copy link

Done some rust before, can I try this one?

@tholop
Copy link
Member Author

tholop commented Apr 3, 2021

That would be helpful, thanks! There are some good candidates in https://github.com/OpenMined/sycret/blob/master/src/eq.rs and le.rs in particular. Let me know if you have any questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimasquest dimasquest

Labels
Good first issue 🎓 Perfect for beginners, welcome to OpenMined! Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dimasquest @tholop