Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance degradation for higher batch size on PPC64LE #5085

Open
pratiklp00 opened this issue Jan 21, 2025 · 2 comments
Open

Performance degradation for higher batch size on PPC64LE #5085

pratiklp00 opened this issue Jan 21, 2025 · 2 comments

Comments

@pratiklp00
Copy link

pratiklp00 commented Jan 21, 2025

Hi,
While running the large batch size model we have observed the performance degradation. We were able to trace it back to #4920

@martin-frbg
Copy link
Collaborator

That's bad but my impression was that it is a question of right vs faster. It is possible of course that it is a specific corner case that needed fixing rather than the algorithm in general, or that #4920 papers over an actual issue elsewhere.

@pratiklp00
Copy link
Author

pratiklp00 commented Jan 28, 2025

Hi @martin-frbg Thank you for your response. We haven't observed the zgemm/cgemm test failure on PPC64LE. Would it be possible to implement a conditional check for PPC so that we can continue using the previous code? If not, could you guide me on the best way to proceed with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants