Deprecate Date_Short and removed strftime #4462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate Class because the values are strftime format strings removed strftime and replace with date calls
Somehow the quotation marks changed? |
sreichel
approved these changes
Jan 8, 2025
addison74
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Deprecated Mage_Adminhtml_Model_System_Config_Source_Date_Short because it uses strftime format strings as values.
Replaced strftime with date
Related Pull Requests
Fixed Issues (if relevant)
strftimespresent: #4398Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)