Add support for integrated kernel driver #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an env. var "INTEGRATED_DRIVER" is set to `true` (or similar) then modify the behavior of dss_host.py: 1. Never unload nvme or nvme-core drivers 2. Use modprobe instead of insmod for nvme-fabrics, nvme-tcp, and nvme-rdma 3. Do not modprobe nvme unnecessarilly (in `remove` function) Additionally, I implemented a fix where we are indiscriminately attempting to process all nvme subsystems. Now we are only processing RDMA subsystems.
velomatt
force-pushed
the
Add-support-for-integrated-kernel-driver
branch
from
c4bad34
to
2255a4d
Compare
grandsuri
approved these changes
Jun 3, 2024
|
Build is presently failing due to an issue with Sonar-Scanner. https://community.sonarsource.com/t/403-errors-on-sonar-scanner-cli-since-v6-upgrade/116407/9 I'll re-run the build once there's a fix upstream. |
|
|
looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an env. var "INTEGRATED_DRIVER" is set to
true(or similar) then modify the behavior of dss_host.py:removefunction)Additionally, I implemented a fix where we are indiscriminately attempting to process all nvme subsystems.
Now we are only processing RDMA subsystems.