Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some descriptive --screen-mode arguments #26

Open
zhouruixi opened this issue Oct 20, 2024 · 4 comments
Open

Add some descriptive --screen-mode arguments #26

zhouruixi opened this issue Oct 20, 2024 · 4 comments

Comments

@zhouruixi
Copy link

zhouruixi commented Oct 20, 2024

-screen-mode arguments only support <width>x<heigth>@<fps>. How about add some descriptive --screen-mode arguments, like max-fps, min-fps, max-resolution, min-resolution etc. Then PixelPilot_rk selects a suitable screen mode from the screen modes supported by the monitor.

@seriyps
Copy link
Collaborator

seriyps commented Oct 20, 2024

Great idea 👍

What is "mix-resolution"?

@zhouruixi
Copy link
Author

mix-resolution

it's a typo, min-resolution

@seriyps
Copy link
Collaborator

seriyps commented Oct 21, 2024

While working on #28, I found interesting is that this structure which represents supported display mode https://www.kernel.org/doc/html/latest/gpu/drm-kms.html#c.drm_display_mode
Has a .type field and it can have DRM_MODE_TYPE_PREFERRED flag set, and I think it should be used as default resolution if nothing is explicitly specified

@zhouruixi
Copy link
Author

zhouruixi commented Oct 22, 2024

While working on #28, I found interesting is that this structure which represents supported display mode https://www.kernel.org/doc/html/latest/gpu/drm-kms.html#c.drm_display_mode Has a .type field and it can have DRM_MODE_TYPE_PREFERRED flag set, and I think it should be used as default resolution if nothing is explicitly specified

Yes, it had a preferred, This should be the default screenmode. May due to compatibility issues, the preferred may not be the best. Or just order by fps, resolution desc and use the first one screen mode?

apt install drm-info
drm_info
You can see the connector modes, my monitor supports 2560x1080@75, but the preferred is 2560x1080@60

│   └───Connector 1
│       ├───Object ID: 111
│       ├───Type: HDMI-A
│       ├───Status: connected
│       ├───Physical size: 800x340 mm
│       ├───Subpixel: unknown
│       ├───Encoders: {1}
│       ├───Modes
│       │   ├───[email protected] preferred driver phsync nvsync 
│       │   ├───[email protected] driver phsync nvsync 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants