Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

question about let #85

Open
mxjmtxrm opened this issue Jul 8, 2024 · 0 comments
Open

question about let #85

mxjmtxrm opened this issue Jul 8, 2024 · 0 comments

Comments

@mxjmtxrm
Copy link

mxjmtxrm commented Jul 8, 2024

Hi,
Why exclude down_proj when executing a let? like model.mlp.down_proj.temp_weight = model.mlp.down_proj.weight.
I think the down_proj can be smoothed with up_proj, like smooth_fc_fc_temporary(model.mlp.up_proj,model.mlp.down_proj, model.down_smooth_scale, model.down_smooth_shift)
Am I right?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mxjmtxrm