Common add assert() function #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephjclark
requested changes
Jan 12, 2025
There was a problem hiding this comment.
Thanks @PiusKariuki - what a pleasant surprise! Thank you for such a fully-featured and comprehensive PR, we really appreciate it.
There's one big issue with the return which we'll need to resolve, plus a couple of minor comments which it would be nice to address 🙏
josephjclark
approved these changes
Jan 12, 2025
There was a problem hiding this comment.
Thank you @PiusKariuki!
As on the other PR, can you please generate a changeset file - pnpm changeset. This will also be a minor release.
Tomorrow I'll merge both of these changes to a branch in the repo, run a bit of QA, and release to the world!
|
Thank you for the very helpful reviews @josephjclark ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added an 'assert' function to the common adaptor
Fixes #876
Details
Created an assert function that aborts execution when it fails.
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Review Checklist
Before merging, the reviewer should check the following items:
dev only changes don't need a changeset.