-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch Kobo API 404 errors instead of letting job fail [GRM] #238
Comments
@ritazagoni this is the same spec as #237 yeah? Except targeting a different job, correct? Just want to make sure, and will update the issue description above accordingly to give the devs a heads up. |
Note for Marta: Small change request for the client. |
@hunterachieng estimate is needed. Should be the quick one :) |
@ritazagoni and @aleksa-krolls I am unable to access the link of this file getGrmKoboData.js |
hey @hunterachieng try now pls, thanks! |
@aleksa-krolls I have access. Thank you |
@hunterachieng when you start work on this issue, please see the important notes above and work off the designated branch! |
@aleksa-krolls This issue has been approved. Do you mind testing it? Here is the PR. Please also note the version of |
Background, context, and business value
This builds on #237 and will reuse code from that implementation.
We are fetching a list of Kobo forms from GoogleSheets then running the getGrmKoboData job to fetch submissions from those forms. However, sometimes those forms are not shared with the Kobo credential owner, which results in a 404.
Currently the job fails and halts if a 404 error occurs. Instead, we would like it to continue and store the forms that caused the 404 for printing/syncing back to GoogleSheets so that we can follow up.
A clear and concise description of what you want to happen.
Basically re-use the same pattern for what was implemented in #237, but will be implemented to this
Grm
job which connects to a different Kobo account and has slightly different behavior.In the getGrmKoboData job
and/or
fetch-grm-404-error-handling
Input
See grm_surveys_inputs.json and again be sure to work on this branch
fetch-grm-404-error-handling
Credential
LP
WCS Kobo Global Aggregation Account
adaptor
[email protected]
expression.js
getGrmKoboData
The text was updated successfully, but these errors were encountered: