Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[All connectors] Invalid valid_from/valid_until logic affecting decay mechanisms on OpenCTI Platform #3244

Open
helene-nguyen opened this issue Jan 9, 2025 · 0 comments
Labels
feature use for describing a new feature to develop filigran support [optional] use to identify an issue related to feature developed & maintained by Filigran. technical improvement Technical refactor or improvement is needed

Comments

@helene-nguyen
Copy link
Member

Use case

A problem has been identified in the RF connector that could potentially impact other connectors and compromise best practices for developing import connectors.

Problem:

The valid_from and valid_until fields generated in Python within the RF connector logic are not predictive, contrary to the expectations of OpenCTI platform's mechanisms. These fields, like IDs, must always be predictive. Otherwise, it is preferable to leave them empty, allowing the platform to populate them with its algorithms and rules.

Currently, using now for these fields when no data is provided disrupts the decay logic and other business processes implemented within OpenCTI. Moreover, this approach is redundant, as the platform already defaults to now when the fields are left empty.

In the case of RF, it is expected behavior for the platform to receive the same indicator multiple times if it is modified over time. However, overriding the decay logic with now creates issues:

  1. Misalignment with OpenCTI's predictive and decay logic.
  2. Reduced reliability of the business rules and algorithms in place.

Proposed Solution:

To check in all connectors

  • Preferred: Use a creation date (original and immutable) provided by RF in the valid_from field.
  • Alternative: If no such date is available, leave the valid_from and valid_until fields empty to allow the platform to handle them automatically.

Impact:

This issue affects the decay mechanisms and business logic that rely on accurate and predictive timestamps. Addressing this is critical to maintaining data integrity and ensuring adherence to development best practices for connectors.

@helene-nguyen helene-nguyen added feature use for describing a new feature to develop filigran team use to identify PR from the Filigran team technical improvement Technical refactor or improvement is needed labels Jan 9, 2025
@helene-nguyen helene-nguyen changed the title [All connectors] Invalid valid_from/valid_until logic affecting decay nechanisms on OpenCTI Platform [All connectors] Invalid valid_from/valid_until logic affecting decay mechanisms on OpenCTI Platform Jan 9, 2025
@helene-nguyen helene-nguyen added filigran support [optional] use to identify an issue related to feature developed & maintained by Filigran. and removed filigran team use to identify PR from the Filigran team labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature use for describing a new feature to develop filigran support [optional] use to identify an issue related to feature developed & maintained by Filigran. technical improvement Technical refactor or improvement is needed
Projects
None yet
Development

No branches or pull requests

1 participant