Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting the sha via the Heroku API will fail after 200 commits #8

Open
pezholio opened this issue Jan 13, 2015 · 0 comments
Open

Getting the sha via the Heroku API will fail after 200 commits #8

pezholio opened this issue Jan 13, 2015 · 0 comments

Comments

@pezholio
Copy link
Member

At the moment, we get the commit sha for the provenance using the Heroku API, which is a bit messy, but due to the lack of a filesystem, we can't use Git to get the current SHA:

https://github.com/OpenAddressesUK/distiller/blob/master/lib/helpers.rb#L12

Also, this will break eventually as the Heroku API gem only returns the first 200 commits. We probably need to fix this before we hit 200 commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant