[Bug]: dependency conflict on Android #1545

CrashingTheCode · 2023-08-30T11:28:22Z

What happened?

The android build fails with this error:
Duplicate class androidx.work.OneTimeWorkRequestKt found in modules work-runtime-2.8.0-runtime (androidx.work:work-runtime:2.8.0) and work-runtime-ktx-2.7.1-runtime (androidx.work:work-runtime-ktx:2.7.1)
Duplicate class androidx.work.PeriodicWorkRequestKt found in modules work-runtime-2.8.0-runtime (androidx.work:work-runtime:2.8.0) and work-runtime-ktx-2.7.1-runtime (androidx.work:work-runtime-ktx:2.7.1)

Go to the documentation to learn how to Fix dependency resolution errors.

Steps to reproduce?

1. Install react-native-onesignal 5.0.0
2. build on android

What did you expect to happen?

I expected a successful build

React Native OneSignal SDK version

Release 5.0.0

Which platform(s) are affected?

iOS
Android

Relevant log output

Duplicate class androidx.work.OneTimeWorkRequestKt found in modules work-runtime-2.8.0-runtime (androidx.work:work-runtime:2.8.0) and work-runtime-ktx-2.7.1-runtime (androidx.work:work-runtime-ktx:2.7.1)
Duplicate class androidx.work.PeriodicWorkRequestKt found in modules work-runtime-2.8.0-runtime (androidx.work:work-runtime:2.8.0) and work-runtime-ktx-2.7.1-runtime (androidx.work:work-runtime-ktx:2.7.1)

Go to the documentation to learn how to Fix dependency resolution errors.

Code of Conduct

I agree to follow this project's Code of Conduct

jennantilla · 2023-08-31T00:19:26Z

@CrashingTheCode thanks for reaching out! We'll investigate this and get back to you as soon as possible.

KodyKendall · 2023-09-08T13:00:52Z

I am running into this same issue, I believe it's a "transitive dependency conflict" where I have another package in my react-native project that is pulling in androidx.work:work-runtime, and they have conflicting versions.

It's the com.onesignal:notifications:5.0.0 package that has this dependency.

+--- project :react-native-onesignal
|    +--- com.onesignal:OneSignal:5.0.0
|    |    +--- com.onesignal:core:5.0.0
|    |    |    +--- androidx.legacy:legacy-support-v4:{require [1.0.0, 1.0.99]; prefer 1.0.0} -> 1.0.0 (*)
|    |    |    +--- androidx.appcompat:appcompat:{require [1.0.0, 1.3.99]; prefer 1.3.1} -> 1.6.1 (*)
|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.7.10 -> 1.8.10 (*)
|    |    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4 (*)
|    |    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4 (*)
|    |    +--- com.onesignal:notifications:5.0.0
|    |    |    +--- com.google.firebase:firebase-messaging:{require [19.0.0, 23.0.99]; prefer 23.0.0} -> 22.0.0 (*)
**|    |    |    +--- **androidx.work:work-runtime:{require [2.1.0, 2.7.99]; prefer 2.7.1} -> 2.8.0 (*)****
|    |    |    +--- com.onesignal:core:5.0.0 (*)
|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.7.10 -> 1.8.10 (*)
|    |    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4 (*)
|    |    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4 (*)
|    |    |    +--- androidx.work:work-runtime-ktx:2.7.1
|    |    |    |    +--- androidx.work:work-runtime:2.7.1 -> 2.8.0 (*)
|    |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.8.10 (*)
|    |    |    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.0 -> 1.6.4 (*)

And in my case, it's conflicting with:

+--- project :notifee_react-native
|    +--- com.facebook.react:react-native:+ -> com.facebook.react:react-android:0.72.4 (*)
|    +--- app.notifee:core:+ -> 202108261754
|    +--- androidx.concurrent:concurrent-futures:1.1.0 (*)
|    +--- com.google.android.gms:play-services-tasks:18.0.1
|    |    \--- com.google.android.gms:play-services-basement:18.0.0
|    |         +--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
|    |         +--- androidx.core:core:1.2.0 -> 1.9.0 (*)
|    |         \--- androidx.fragment:fragment:1.0.0 -> 1.5.7 (*)
**|    +--- androidx.work:work-runtime:2.8.0**

KodyKendall · 2023-09-08T13:14:28Z

I was able to resolve this by going into my android/app/build.gradle file adding the following lines:

android {
    namespace "com.yourapp.package"
    ...

    configurations.all {
         resolutionStrategy.force 'androidx.work:work-runtime:2.7.1' //<-- this came from the notifee library having a dependency on androidx.work:work-runtime:2.8.0' and OneSignal having a dependency on androidx:work:work-runtime:2.7.1
    }
}

aryalprakash · 2023-09-08T16:45:47Z

I was able to resolve this by going into my android/app/build.gradle file adding the following lines:

android {
    namespace "com.yourapp.package"
    ...

    configurations.all {
         resolutionStrategy.force 'androidx.work:work-runtime:2.7.1' //<-- this came from the notifee library having a dependency on androidx.work:work-runtime:2.8.0' and OneSignal having a dependency on androidx:work:work-runtime:2.7.1
    }
}

This worked. Thanks @KodyKendall

jwhenshaw · 2023-09-11T11:54:15Z

For anyone else who comes across this but would like to ensure the use of androidx.work:work-runtime:2.8.0, as I wanted this patch w.r.t to using Notifee, then I used the below snippet within my app build.gradle to force the resolution.

    // Force androidx.work:work-runtime andwork-runtime-ktx  to use version 2.8.0
    // due to transitive dependancy conflict between notifee and OneSignal
    api(group: "androidx.work", name: "work-runtime") {
        version {
            strictly "2.8.0"
        }
    }
        api(group: "androidx.work", name: "work-runtime-ktx") {
        version {
            strictly "2.8.0"
        }
    }

Note, I'm not sure if this is the correct way to achieve this as I'm new to the world of ReactNative + Android but its working so far for me (and as it is a minor version bump I'm assuming it should be okay)

Hope this helps someone

jennantilla · 2023-11-16T19:48:52Z

Hello all! Just a quick update that we have updated our androidx.work:work-runtime to prefer the latest version, 2.8.1. Version 5.0.3 of the React Native plugin reflects this.

Please let us know if you have any additional questions or concerns.

getadapt · 2023-11-19T12:43:22Z

Hi -- thanks for this, but not sure this is fixed in 5.0.3 as we're still getting the above build error. We use expo managed builds in our workflow so needed the above patch to be put into our android/app/build.gradle programmatically. If anyone finds this who is also on expo, we have things building smoothly again using the following (ugly!) expo mod:

    mods: {
      android: {
        appBuildGradle: (config) => {
          let appBuildGradleFile = config.modResults.contents as string;
          // if you change these lines, always run prebuild clean afterwards (npx expo prebuild --platform android --clean)
          const newLines = [
            "    // start mod fix for notifee onesignal clash",
            "    configurations.all {",
            "         resolutionStrategy.force 'androidx.work:work-runtime:2.8.1' //<-- from mod",
            "         resolutionStrategy.force 'androidx.work:work-runtime-ktx:2.8.1' //<-- from mod",
            "    }",
            "    // end mod fix for notifee onesignal clash",
          ];

          const newLinesBlock = newLines.join("\n");

          // remove if already there lol
          appBuildGradleFile = appBuildGradleFile.replace(newLinesBlock, "");

          const lines = appBuildGradleFile.split("\n");

          // change line number as needed!
          lines.splice(114, 0, newLinesBlock);

          config.modResults.contents = lines.join("\n");

          return config;
        },
      },
    },

SohelIslamImran · 2024-01-03T05:27:23Z

Here is config plugin for expo.

const { withAppBuildGradle } = require("@expo/config-plugins");
const generateCode = require("@expo/config-plugins/build/utils/generateCode");

// https://github.com/OneSignal/react-native-onesignal/issues/1545
const onesignalAndroidXConflictWorkaroundCode = `
    configurations.all {
        resolutionStrategy.force 'androidx.work:work-runtime:2.8.1'
        resolutionStrategy.force 'androidx.work:work-runtime-ktx:2.8.1'
    }
`;

module.exports = (config) => {
  return withAppBuildGradle(config, async (config) => {
    const addCode = generateCode.mergeContents({
      newSrc: onesignalAndroidXConflictWorkaroundCode,
      tag: "onesignalAndroidXConflictWorkaroundCode",
      src: config.modResults.contents,
      anchor: /\s*namespace/i,
      comment: "//",
      offset: 1,
    });

    config.modResults.contents = addCode.contents;

    return config;
  });
};

short-dsb · 2024-01-16T22:02:53Z

Hi, @jennantilla! Thanks for investigating this. 🙂 Sorry to comment on a closed issue, but it’s still occurring in the latest release (5.0.4).

Now that the issue is fixed in 5.1.1, can we update the dependency in this project to resolve the build issue here?

I can confirm making this change locally in node_modules/react-native-onesignal/android/build.gradle results in a successful build:

- api 'com.onesignal:OneSignal:5.0.5'
+ api 'com.onesignal:OneSignal:5.1.1'

Lurtroxx · 2024-01-17T00:59:03Z

I can confirm still occurring in latest release! Just went to install today, and having this problem right now! @short-dsb

jennantilla · 2024-01-17T17:38:25Z

@short-dsb we will be working on getting an update out for wrappers including React Native as soon as possible.

@Lurtroxx are you still experiencing this on 5.1.1 of the native Android SDK?

Lurtroxx · 2024-01-17T17:46:26Z

Yes both android and ios, the solution was to put this script given by @SohelIslamImran into the root and run it upon build.

Here is config plugin for expo.

const { withAppBuildGradle } = require("@expo/config-plugins");
const generateCode = require("@expo/config-plugins/build/utils/generateCode");

// https://github.com/OneSignal/react-native-onesignal/issues/1545
const onesignalAndroidXConflictWorkaroundCode = `
    configurations.all {
        resolutionStrategy.force 'androidx.work:work-runtime:2.8.1'
        resolutionStrategy.force 'androidx.work:work-runtime-ktx:2.8.1'
    }
`;

module.exports = (config) => {
  return withAppBuildGradle(config, async (config) => {
    const addCode = generateCode.mergeContents({
      newSrc: onesignalAndroidXConflictWorkaroundCode,
      tag: "onesignalAndroidXConflictWorkaroundCode",
      src: config.modResults.contents,
      anchor: /\s*namespace/i,
      comment: "//",
      offset: 1,
    });

    config.modResults.contents = addCode.contents;

    return config;
  });
};

SohelIslamImran · 2024-01-18T07:49:55Z

Yes both android and ios, the solution was to put this script given by @SohelIslamImran into the root and run it upon build.

I've faced this issue only on Android not ios.

DLI0740-chaithanyaa · 2024-09-05T07:02:23Z

I was able to resolve this by going into my android/app/build.gradle file adding the following lines:

android {
    namespace "com.yourapp.package"
    ...

    configurations.all {
         resolutionStrategy.force 'androidx.work:work-runtime:2.7.1' //<-- this came from the notifee library having a dependency on androidx.work:work-runtime:2.8.0' and OneSignal having a dependency on androidx:work:work-runtime:2.7.1
    }
}

This worked for me @KodyKendall 🥳 thank you...

jennantilla closed this as completed Nov 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug]: dependency conflict on Android #1545

[Bug]: dependency conflict on Android #1545

CrashingTheCode commented Aug 30, 2023 •

edited by github-actions bot

Loading

jennantilla commented Aug 31, 2023

KodyKendall commented Sep 8, 2023

KodyKendall commented Sep 8, 2023 •

edited

Loading

aryalprakash commented Sep 8, 2023

jwhenshaw commented Sep 11, 2023

jennantilla commented Nov 16, 2023

getadapt commented Nov 19, 2023

SohelIslamImran commented Jan 3, 2024

short-dsb commented Jan 16, 2024

Lurtroxx commented Jan 17, 2024

jennantilla commented Jan 17, 2024

Lurtroxx commented Jan 17, 2024

SohelIslamImran commented Jan 18, 2024 •

edited

Loading

DLI0740-chaithanyaa commented Sep 5, 2024

[Bug]: dependency conflict on Android #1545

[Bug]: dependency conflict on Android #1545

Comments

CrashingTheCode commented Aug 30, 2023 • edited by github-actions bot Loading

What happened?

Steps to reproduce?

What did you expect to happen?

React Native OneSignal SDK version

Which platform(s) are affected?

Relevant log output

Code of Conduct

jennantilla commented Aug 31, 2023

KodyKendall commented Sep 8, 2023

KodyKendall commented Sep 8, 2023 • edited Loading

aryalprakash commented Sep 8, 2023

jwhenshaw commented Sep 11, 2023

jennantilla commented Nov 16, 2023

getadapt commented Nov 19, 2023

SohelIslamImran commented Jan 3, 2024

short-dsb commented Jan 16, 2024

Lurtroxx commented Jan 17, 2024

jennantilla commented Jan 17, 2024

Lurtroxx commented Jan 17, 2024

SohelIslamImran commented Jan 18, 2024 • edited Loading

DLI0740-chaithanyaa commented Sep 5, 2024

CrashingTheCode commented Aug 30, 2023 •

edited by github-actions bot

Loading

KodyKendall commented Sep 8, 2023 •

edited

Loading

SohelIslamImran commented Jan 18, 2024 •

edited

Loading