-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[User Model] Rename Events & API Changes #1524
[User Model] Rename Events & API Changes #1524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few points of feedback:
- Left a comment on the migration guide in-line
- Omit new files under
android/.gradle
andandroid./idea
that were added i this PR - I see your other PRs covered the lint and other renaming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry there are so many comments. I didn't want to lose anything as I went through this PR.
I'm not going to request changes as your two other PRs build off this, especially the prettier
PR is pretty hefty and touches all the files. We can look at making any changes in a later PR.
OR, we can always toss the current prettier
PR changes and rerun prettier
, and cherry pick the migration guide fixes, in order to add additional changes to this PR.
There are some extra files committed and usually the ones that sound like .gradle
or .idea
are extraneous files.
@nan-li as disccussed, for a cleaner merge, all changes requested have been incorporated in this branch. Commit addressing each comment linked above. Thanks for the feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as changes are addressed in following PR #1532
Description
One Line Summary
This is a large PR that includes changes to events and public APIs across multiple features in the SDK to reflect the updates in the native iOS and Android 5.0.0-beta4 SDKs.
Privacy
Live Activities
enter
andexit
methods.PermissionNative
OSNotificationPermission
, that is the notification permission status of the device. The status can be NotDetermined, Denied, Authorized, and in addition for iOS devices - Provisional, Ephemeral.In App Messages
addEventListener
method (see below)AddTrigger(string key, string value)
andAddTriggers(Dictionary<string, string> triggers)
Notifications
addEventListener
method (see below):Push Subscription
onOSPushSubscriptionChange
withOSPushSubscriptionState
state parameter ofprevious
andcurrent
Details
Motivation
Update to updated user model API
Scope
In Live Activities, App Messages, Notifications, Subscriptions, Permissions, Privacy Consent
Testing
Manual testing
Tested naming updates on Samsung Galaxy S21 & Pixel 4 running Android 13 / 6th gen iPad running 16.4.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is