[Bug]: App crashes on launch NSInvalidArgumentException - *** -[__NSPlaceholderArray initWithObjects:count:]: attempt to insert nil object from objects[1]

[sachithras]

What happened?

App crashes at launch, crashes are reported for only one user but multiple times (46 times), error description says App crashes on launch NSInvalidArgumentException - *** -[__NSPlaceholderArray initWithObjects:count:]: attempt to insert nil object from objects[1]

Steps to reproduce?

1. Launch the app (the firebase crash log is pasted for reference)

What did you expect to happen?

App should open without crashing

OneSignal iOS SDK version

Release 3.12.3

iOS version

15

Specific iOS version

+ iOS 15.7.3

Relevant log output

Fatal Exception: NSInvalidArgumentException
0  CoreFoundation                 0x92c80 (Missing UUID 55c76f8ebcc93a4c9f6216eac0ba8ab8)
1  libobjc.A.dylib                0x14ee4 objc_exception_throw
2  CoreFoundation                 0x18d6b4 (Missing UUID 55c76f8ebcc93a4c9f6216eac0ba8ab8)
3  CoreFoundation                 0x18b0d8 (Missing UUID 55c76f8ebcc93a4c9f6216eac0ba8ab8)
4  CoreFoundation                 0x1fd28 (Missing UUID 55c76f8ebcc93a4c9f6216eac0ba8ab8)
5  CoreFoundation                 0x4973c (Missing UUID 55c76f8ebcc93a4c9f6216eac0ba8ab8)
6  OneSignal                      0x2e23c (Missing UUID ef4fff29da83381d8c05578e1b715417)
7  GoogleUtilities                0x6d2c (Missing UUID ff85b286b7093c03bdd66fc0154cd395)
8  libdispatch.dylib              0x63094 _dispatch_call_block_and_release
9  libdispatch.dylib              0x64094 _dispatch_client_callout
10 libdispatch.dylib              0x10d44 _dispatch_main_queue_drain
11 libdispatch.dylib              0x10994 _dispatch_main_queue_callback_4CF$VARIANT$mp
12 CoreFoundation                 0x4e034 (Missing UUID 55c76f8ebcc93a4c9f6216eac0ba8ab8)
13 CoreFoundation                 0xb538 (Missing UUID 55c76f8ebcc93a4c9f6216eac0ba8ab8)
14 CoreFoundation                 0x1e194 (Missing UUID 55c76f8ebcc93a4c9f6216eac0ba8ab8)
15 GraphicsServices               0x1988 GSEventRunModal
16 UIKitCore                      0x4e5a88 -[UIApplication _run]
17 UIKitCore                      0x27efc8 UIApplicationMain
18 libswiftUIKit.dylib            0x27ee4 UIApplicationMain(_:_:_:_:)
19 早报                             0x4d04 main (ZBClubNavigationStyle.swift)
20 ???                            0x1058984d0 (Missing)

Code of Conduct

• I agree to follow this project's Code of Conduct

[emawby]

@sachithras Thank you for reporting do you have any more context about what OneSignal methods are being called leading to this crash? Do you know what the missing UUIDs are about?

[dimacorp]

We have same crash with a bit more information:

#0 (null) in __exceptionPreprocess ()
#1 (null) in objc_exception_throw ()
#2 (null) in _CFThrowFormattedException ()
#3 (null) in -[__NSPlaceholderDictionary initWithObjects:forKeys:count:].cold.5 ()
#4 (null) in -[__NSPlaceholderDictionary initWithObjects:forKeys:count:] ()
#5 (null) in +[NSDictionary dictionaryWithObjects:forKeys:count:] ()
#6 (null) in +[OneSignalTrackFirebaseAnalytics trackInfluenceOpenEvent] ()
#7 (null) in +[OneSignal registerUserInternal] ()

Looking at this part in trackInfluenceOpenEvent it does not seem safe, dictionary can't hold nil's which is default line above:

NSString *notificationId = [sharedUserDefaults getSavedStringForKey:ONESIGNAL_FB_LAST_NOTIFICATION_ID_RECEIVED defaultValue:nil];
NSString *campaign = [sharedUserDefaults getSavedStringForKey:ONESIGNAL_FB_LAST_GAF_CAMPAIGN_RECEIVED defaultValue:nil];

[self logEventWithName:@"os_notification_influence_open"
            parameters:@{
                @"source": @"OneSignal",
                @"medium": @"notification",
                @"notification_id": notificationId,
                @"campaign": campaign
            }];

Any idea what's going on and how to fix?
The crash happens when opening app from push notification.

[maxim-velich-gismart]

@emawby Hello. I have the same issue for version 3.12.5

Fatal Exception: NSInvalidArgumentException
0 CoreFoundation 0x9cb4 __exceptionPreprocess
1 libobjc.A.dylib 0x183d0 objc_exception_throw
2 CoreFoundation 0x1aff84 -[__NSCFString characterAtIndex:].cold.1
3 CoreFoundation 0x1bb4ac -[__NSPlaceholderDictionary initWithCapacity:].cold.1
4 CoreFoundation 0x2545c -[__NSPlaceholderDictionary initWithObjects:forKeys:count:]
5 CoreFoundation 0x252fc +[NSDictionary dictionaryWithObjects:forKeys:count:]
6 OneSignalCore 0x130ac (Missing UUID 28b5fe94c57737e796c3316d22dae287)
7 OneSignal 0xfa5c (Missing UUID 5a7e778e4c65352b8b682f18be52eb54)
8 libdispatch.dylib 0x2320 _dispatch_call_block_and_release
9 libdispatch.dylib 0x3eac _dispatch_client_callout
10 libdispatch.dylib 0x126a4 _dispatch_main_queue_drain
11 libdispatch.dylib 0x122f4 _dispatch_main_queue_callback_4CF
12 CoreFoundation 0x98c28 CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE
13 CoreFoundation 0x7a560 __CFRunLoopRun
14 CoreFoundation 0x7f3ec CFRunLoopRunSpecific
15 GraphicsServices 0x135c GSEventRunModal
16 UIKitCore 0x39d6e8 -[UIApplication _run]
17 UIKitCore 0x39d34c UIApplicationMain
18 0x10f28c main + 14 (AppDelegate.swift:14)
19 ??? 0x1d88aedec (Missing)

[emawby]

Thank you for reporting we will investigate the issue