You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
According to the link graph construction description from the paper, the graph should also contain interaction between real-spots.
However, in the current implementation (modified from the original implementation, see Su-informatics-lab/DSTG#16), only the cross interactions between pseudo-spots and real-spots are used.
Should we add the interactions between real-spots as described in the manuscript in the DANCE implementation? If so, it could be achieved quite easily by simply calling construct_link_graph one more time by passing real_st_df as both first two args and combine the edge list with the old graph.
Caution: be aware that one might need to modify the the new graph node indexes (or pass real_st_df and another copy of real_st_df with offsetted index)
The text was updated successfully, but these errors were encountered:
RemyLau
changed the title
DSTG link graph should add connections between real spots
DSTG link graph add connections between real spots?
Dec 31, 2022
According to the link graph construction description from the paper, the graph should also contain interaction between real-spots.
However, in the current implementation (modified from the original implementation, see Su-informatics-lab/DSTG#16), only the cross interactions between pseudo-spots and real-spots are used.
dance/dance/transforms/graph/dstg_graph.py
Line 59 in 9966c47
Should we add the interactions between real-spots as described in the manuscript in the DANCE implementation? If so, it could be achieved quite easily by simply calling
construct_link_graph
one more time by passingreal_st_df
as both first two args and combine the edge list with the old graph.Caution: be aware that one might need to modify the the new graph node indexes (or pass
real_st_df
and another copy ofreal_st_df
with offsetted index)The text was updated successfully, but these errors were encountered: