Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSTG link graph add connections between real spots? #104

Open
RemyLau opened this issue Dec 31, 2022 · 1 comment
Open

DSTG link graph add connections between real spots? #104

RemyLau opened this issue Dec 31, 2022 · 1 comment
Labels
question Further information is requested

Comments

@RemyLau
Copy link
Collaborator

RemyLau commented Dec 31, 2022

According to the link graph construction description from the paper, the graph should also contain interaction between real-spots.

image

However, in the current implementation (modified from the original implementation, see Su-informatics-lab/DSTG#16), only the cross interactions between pseudo-spots and real-spots are used.

graph = construct_link_graph(pseudo_st_df, real_st_df, k_filter, num_cc)

Should we add the interactions between real-spots as described in the manuscript in the DANCE implementation? If so, it could be achieved quite easily by simply calling construct_link_graph one more time by passing real_st_df as both first two args and combine the edge list with the old graph.

Caution: be aware that one might need to modify the the new graph node indexes (or pass real_st_df and another copy of real_st_df with offsetted index)

@RemyLau RemyLau changed the title DSTG link graph should add connections between real spots DSTG link graph add connections between real spots? Dec 31, 2022
@RemyLau RemyLau added the question Further information is requested label Dec 31, 2022
@RemyLau
Copy link
Collaborator Author

RemyLau commented Jan 4, 2023

The authors have confirmed that we should combine both graphs (see Su-informatics-lab/DSTG#16 (comment)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant