Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add targetGasLimit to the cluster_definition to allow the creation of clusters with higher gas targets #3419

Open
5 tasks
OisinKyne opened this issue Dec 12, 2024 · 0 comments
Assignees
Labels
protocol Protocol Team tickets
Milestone

Comments

@OisinKyne
Copy link
Contributor

🎯 Problem to be solved

The community wants to raise the target gas limit. Currently that is not easy to do in Charon.

🛠️ Proposed solution

The challenge here, is trying to coordinate all VCs to sign a higher limit. This is something we attempted early in charon development, and disfavoured over signing a single registration at the point of dkg or key splitting.

To begin, I suggest we stick to the key splitting/dkg moment, but further more realtime approaches may be considered in future.

The suggestion is to include a target_gas_limit field in a new version of the cluster_definition object. With a default of 36m. This could be overridden with the flag --target-gas-limit int The target block gas limit for the cluster (Default: 36000000)

This const https://github.com/ObolNetwork/charon/blob/main/core/validatorapi/validatorapi.go#L36 is what should be parameterized.

  • Approved design doc: link
  • Core team consensus on the proposed solution

Describe the solution to be implemented

🧪 Tests

  • Tested by new automated unit/integration/smoke tests
  • Manually tested on core team/canary/test clusters
  • Manually tested on local compose simnet
@OisinKyne OisinKyne added this to the v1.3.0 milestone Dec 12, 2024
@github-actions github-actions bot added the protocol Protocol Team tickets label Dec 12, 2024
@KaloyanTanev KaloyanTanev self-assigned this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol Protocol Team tickets
Projects
None yet
Development

No branches or pull requests

2 participants