-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub issue data and connect with user profiles #3266
Conversation
cf9240c
to
86f3e7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great thank you! Can you please make a model GitHubIssues and store them there instead? Also check the first pr badge logic to only trigger on the first. Also please add a count in the profile.
Did you mean GithubPullRequests instead of issues, or do we want to store them both? Also, in that case, would it be better to use a scheduled command to fetch pr data regularly or the webhook only? |
GitHub issues and pull requests are the same structure in their back end. We want to have GitHub issues along with pull requests so I think we could use one table. |
I also think it will be good to have them be 1 line each so we can see many at one time, and have the counts up top merged, open, closed and rank compare to others merged pull requests |
And group by organization / repository |
Understood! |
Thank you! |
37d9bac
to
955a55a
Compare
In progress |
In the GitHubIssue model, do we intend to store issue data of all existing repositories in the database |
github_url sounds good! |
Overall look: Summary
@DonnieBLT @tsu-ki please take a look |
looks amazing, great work man! Just a small suggestion, rather than displaying PRs from all repos, can we add a dropdown list and add repos to that list, so user can select which repo they want to view. |
Fixes #3265
Extended the
handle_pull_request_event
function to also add the pull request data to the databaseCould you please verify if the webhook is working? Since on the site the pull request badges are not being assigned automatically despite having added the GitHub URL to the profile