Added Feature to recommend Users from profile page #2948

tsu-ki · 2024-11-18T16:37:38Z

Users can recommend other uses directly from their profile page. I've also added a badge which shows the recommended users.
Closes: #2632

Screen.Recording.2024-11-19.at.2.08.44.AM.mov

sentry-io · 2024-11-18T16:37:44Z

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: website/views/user.py

Function	Unhandled Issue
`get_context_data`	UserProfile.user.RelatedObjectDoesNotExist: UserProfile has no user. ... `Event Count:` 270

_{Did you find this useful? React with a 👍 or 👎}

website/views/user.py

DonnieBLT · 2024-11-19T02:14:54Z

This looks good can you please also add a text area where the user can add a recommendation blurb and if there is a blurb then show it on the profile on the bottom of the page otherwise, having the number count is good.

DonnieBLT

Please see the comment for the changes requested and also please make sure the tests are passing

website/forms.py

+        if blurb:
+            # Remove any HTML or template tags
+            blurb = re.sub(r"<[^>]+>", "", blurb)
+            blurb = re.sub(r"{%.*?%}", "", blurb)


website/forms.py

+            # Remove any HTML or template tags
+            blurb = re.sub(r"<[^>]+>", "", blurb)
+            blurb = re.sub(r"{%.*?%}", "", blurb)
+            blurb = re.sub(r"{{.*?}}", "", blurb)


website/views/user.py

+
+
+# Add new view for AJAX blurb recommendations
+@require_POST


website/views/user.py

+
+
+@login_required
+def ajax_recommend_user(request, username):


tsu-ki · 2024-11-23T11:28:58Z

@DonnieBLT Added a recommendation blurb which can be added to a User's Profile from Edit Profile Page.
Also Added a feature using which other users can recommend a user directly by clicking on a "Recommend" button which is visible to other users only(not self), without having to manually recommend a user.
Also added a feature to show the total number of recommendations received. Retained the function to show total number of recommended users.
#2632

Screen.Recording.2024-11-23.at.4.53.53.PM.mov

DonnieBLT

please see comments

.pre-commit-config.yaml

DonnieBLT · 2024-11-24T00:32:25Z

blt/urls.py

@@ -625,6 +628,9 @@
    path("time-logs/", TimeLogListView, name="time_logs"),
    path("sizzle-daily-log/", sizzle_daily_log, name="sizzle_daily_log"),
    path("blog/", include("blog.urls")),
+    path("recommend/<int:user_id>/", recommend_user, name="recommend_user"),


can you be consistent and use either user id or username - and do we need 3 more urls? Can we do this all with one more?

each of the 3 urls determine, recommend users manually(using the dedicated recommendation feature on user profile) , recommend directly from the button under the recommendation blurb and another is ajax recommendation(this was optional and can be removed)

website/forms.py

DonnieBLT

there are a few changes to make also did you ever get permission from @npxpatel to use his code?

DonnieBLT · 2024-11-24T00:56:21Z

website/admin.py

this is missing imports

umm, can you please tell me which imports are missing from this file? I apologise if I missed any

you can check the original here it has the missing import - https://github.com/OWASP-BLT/BLT/pull/2656/files - did you test this code? This would have thrown an error.

DonnieBLT · 2024-11-24T00:59:45Z

code was originally from here #2656

tsu-ki · 2024-11-24T01:04:18Z

there are a few changes to make also did you ever get permission from @npxpatel to use his code?

I did ask him but he never replied

DonnieBLT · 2024-11-24T01:20:25Z

You also copied our badge to a new project without retaining the license?

tsu-ki · 2024-11-24T01:28:21Z

You also copied our badge to a new project without retaining the license?

Actually, I created this project solely to develop a badge for BLT repository which can be used in the README.md file(#2940) and never intended on using it anywhere else. I was going to archive the repository and delete the badge as soon as the corresponding PR for the issue was merged, I waited so just in case the badge I created could come in-use.
I apologise if this created a misunderstanding, I'll delete the created badge so as not to cause any more confusion.
If there's anything else I can do, please do let me know, again, I'm sorry.

tsu-ki · 2024-12-03T17:01:48Z

@DonnieBLT please review the changes I've made to execute the recommendation system and recommendation blurb.

Screen.Recording.2024-12-03.at.10.28.50.PM.mov

tsu-ki · 2024-12-06T19:58:21Z

@DonnieBLT Sir, can you please review the changes I've made and suggest any probable changes, thank you!

DonnieBLT · 2024-12-14T00:25:30Z

this should be liked LinkedIn where you can recommend a user like "this person is a good developer, I recommend them" and it shows the date and image and name of user who recommended them.

tsu-ki · 2024-12-14T09:30:33Z

this should be liked LinkedIn where you can recommend a user like "this person is a good developer, I recommend them" and it shows the date and image and name of user who recommended them.

The current implementation displays the avatar and the name of the person who has recommended the author, as a list in Recommendations. I added a button to recommend the user, rather than a single-time click box, so that people could remove the author from their recommends list, if they felt so.
The recommendations made by the the author are shown in Recommends following the same layout.
I believe only the date function needs to be implemented now, if there's any other changes that I should implement, then please do let me know, thank you

tsu-ki · 2024-12-20T14:24:26Z

@DonnieBLT sir, can you please review the changes I've made in the latest commit.
I've added:

A date-stamp which gets added in both the cases, when a user gives a recommendation or receives one.
The name, avatar and the profile url are displayed in both the "Recommended Users" and "Recommendation Received" lists
Renamed 'Recommendation' to 'About Me', as it's more suitable considering the biography-nature of the Recommendation Blurb.
A dedicated Recommend Section is displayed at the bottom of user profile, using which the users can manually search a user and recommend them, this section is only visible to the author.

Screen.Recording.2024-12-20.at.7.43.25.PM.mov

DonnieBLT · 2024-12-20T14:26:33Z

When you recommend a user, you should be able to insert text

DonnieBLT

Can you please clean this up and remove the unnecessary files and changes check the conflict

tsu-ki · 2024-12-20T14:28:59Z

When you recommend a user, you should be able to insert text
Understood, should I display the text in the same Recommendations list, where the user details are displayed or create a seperate feature altogether?

tsu-ki · 2024-12-26T12:38:37Z

@DonnieBLT Sir I've made the required corrections and resolved the conflicts, Can you please review the changes?

Screen.Recording.2024-12-26.at.6.14.38.PM.mov

tsu-ki · 2024-12-28T14:07:29Z

@DonnieBLT sir can you please review the conflicts and resolve them?

Feature added to recommend Users from profile page

0c5c7e6

github-advanced-security bot found potential problems Nov 18, 2024

View reviewed changes

website/views/user.py Fixed Show fixed Hide fixed

DonnieBLT requested changes Nov 19, 2024

View reviewed changes

tsu-ki requested a review from DonnieBLT November 19, 2024 02:47

Added recommendation blurb feature

5fa1bb6

tsu-ki force-pushed the patch-7 branch from 89f2691 to 81b03c8 Compare November 23, 2024 11:21

github-advanced-security bot found potential problems Nov 23, 2024

View reviewed changes

DonnieBLT requested changes Nov 24, 2024

View reviewed changes

DonnieBLT added the requested changes label Nov 24, 2024

DonnieBLT requested changes Nov 24, 2024

View reviewed changes

DonnieBLT mentioned this pull request Nov 24, 2024

feature to Recommend User on profile page #2656

Closed

Recommendation blurb, total recommendations received

841a522

tsu-ki mentioned this pull request Nov 30, 2024

GSOC 2025 Student Leaderboard #2916

Open

tsu-ki added 2 commits December 1, 2024 00:15

Fixing recommendation blurb button

c46521c

Added Recommendation Blurb and Recommendation Feature

95fd889

tsu-ki force-pushed the patch-7 branch from e7b63ae to 95fd889 Compare December 3, 2024 16:52

tsu-ki requested a review from DonnieBLT December 3, 2024 20:50

Added Datestamp

8adfcb4

DonnieBLT requested changes Dec 20, 2024

View reviewed changes

tsu-ki added 3 commits December 26, 2024 15:21

added recommendation message feature, resolved conflicts

249ad50

resolved conflicts

81afff7

conflict resolved

3ce7a25

tsu-ki force-pushed the patch-7 branch from 3f1372a to 3ce7a25 Compare December 26, 2024 11:01

tsu-ki added 4 commits December 26, 2024 16:45

pre-commit

36f8b9d

pre-commit

a8ea4dd

pre-commit

d1c9b9a

pre-commit

f045d40

tsu-ki force-pushed the patch-7 branch from 5703dcf to f045d40 Compare December 26, 2024 12:21

tsu-ki added 2 commits December 26, 2024 17:59

resolving conflict

f96b428

resolving conflict

2899b75

tsu-ki requested a review from DonnieBLT December 26, 2024 12:38

tsu-ki added 9 commits December 26, 2024 18:27

resolving error

8350048

resolving error

d712bb9

final commit

8020103

final commit

6330a19

final commit

4ec033a

final commit

b8939c5

final final commit

4535e6a

migration file

a3936d6

pre-commit fix

71b6c16

tsu-ki force-pushed the patch-7 branch from b50cd61 to 71b6c16 Compare December 28, 2024 14:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Feature to recommend Users from profile page #2948

Added Feature to recommend Users from profile page #2948

tsu-ki commented Nov 18, 2024 •

edited

Loading

sentry-io bot commented Nov 18, 2024

DonnieBLT commented Nov 19, 2024

DonnieBLT left a comment

tsu-ki commented Nov 23, 2024 •

edited

Loading

DonnieBLT left a comment

DonnieBLT Nov 24, 2024

tsu-ki Nov 24, 2024

DonnieBLT left a comment

DonnieBLT Nov 24, 2024

tsu-ki Nov 24, 2024

DonnieBLT Nov 24, 2024

DonnieBLT commented Nov 24, 2024

tsu-ki commented Nov 24, 2024

DonnieBLT commented Nov 24, 2024

tsu-ki commented Nov 24, 2024 •

edited

Loading

tsu-ki commented Dec 3, 2024 •

edited

Loading

tsu-ki commented Dec 6, 2024

DonnieBLT commented Dec 14, 2024

tsu-ki commented Dec 14, 2024 •

edited

Loading

tsu-ki commented Dec 20, 2024

DonnieBLT commented Dec 20, 2024

DonnieBLT left a comment

tsu-ki commented Dec 20, 2024

tsu-ki commented Dec 26, 2024 •

edited

Loading

tsu-ki commented Dec 28, 2024



		@login_required
		def ajax_recommend_user(request, username):

Added Feature to recommend Users from profile page #2948

Are you sure you want to change the base?

Added Feature to recommend Users from profile page #2948

Conversation

tsu-ki commented Nov 18, 2024 • edited Loading

sentry-io bot commented Nov 18, 2024

🔍 Existing Issues For Review

DonnieBLT commented Nov 19, 2024

DonnieBLT left a comment

Choose a reason for hiding this comment

tsu-ki commented Nov 23, 2024 • edited Loading

DonnieBLT left a comment

Choose a reason for hiding this comment

DonnieBLT Nov 24, 2024

Choose a reason for hiding this comment

tsu-ki Nov 24, 2024

Choose a reason for hiding this comment

DonnieBLT left a comment

Choose a reason for hiding this comment

DonnieBLT Nov 24, 2024

Choose a reason for hiding this comment

tsu-ki Nov 24, 2024

Choose a reason for hiding this comment

DonnieBLT Nov 24, 2024

Choose a reason for hiding this comment

DonnieBLT commented Nov 24, 2024

tsu-ki commented Nov 24, 2024

DonnieBLT commented Nov 24, 2024

tsu-ki commented Nov 24, 2024 • edited Loading

tsu-ki commented Dec 3, 2024 • edited Loading

tsu-ki commented Dec 6, 2024

DonnieBLT commented Dec 14, 2024

tsu-ki commented Dec 14, 2024 • edited Loading

tsu-ki commented Dec 20, 2024

DonnieBLT commented Dec 20, 2024

DonnieBLT left a comment

Choose a reason for hiding this comment

tsu-ki commented Dec 20, 2024

tsu-ki commented Dec 26, 2024 • edited Loading

tsu-ki commented Dec 28, 2024

tsu-ki commented Nov 18, 2024 •

edited

Loading

tsu-ki commented Nov 23, 2024 •

edited

Loading

tsu-ki commented Nov 24, 2024 •

edited

Loading

tsu-ki commented Dec 3, 2024 •

edited

Loading

tsu-ki commented Dec 14, 2024 •

edited

Loading

tsu-ki commented Dec 26, 2024 •

edited

Loading