Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel CpGrid test with aquifer cells is missing. #668

Open
blattms opened this issue Jul 4, 2023 · 3 comments
Open

Parallel CpGrid test with aquifer cells is missing. #668

blattms opened this issue Jul 4, 2023 · 3 comments

Comments

@blattms
Copy link
Member

blattms commented Jul 4, 2023

While looking at OPM/opm-simulators#740 I started wondering whether we actually distribute the information about aquifer cells when load balancing. I hope we do, but we should definitely add one test for that to the test suite. At least could not find one.

@bska
Copy link
Member

bska commented Jul 4, 2023

While looking at OPM/opm-simulators#740

Do you mean OPM/opm-simulators#4740?

I started wondering whether we actually distribute the information about aquifer cells when load balancing.

Kind of. There's nothing in the load balancing step that uses or is aware of numerical aquifers, but once we're running in distributed mode every process/rank's collection of aquifers knows about all numerical aquifers in the model.

@blattms
Copy link
Member Author

blattms commented Jul 5, 2023

While looking at OPM/opm-simulators#740

Do you mean OPM/opm-simulators#4740?

Yes that is what I meant. In AquiferGridUtils.hpp#L52 we ask CpGrid about the aquifer cells, but I cannot find that this information is actually ever transferred to the load balanced grid. For the unbalanced grid the aquifer cells a added when processing the eclipse files it seems.

@bska
Copy link
Member

bska commented Aug 18, 2023

While looking at OPM/opm-simulators#4740 I started wondering whether we actually distribute the information about aquifer cells when load balancing. In AquiferGridUtils.hpp#L52 we ask CpGrid about the aquifer cells, but I cannot find that this information is actually ever transferred to the load balanced grid. For the unbalanced grid the aquifer cells a added when processing the eclipse files it seems.

I didn't get a definite answer to this, but while working on a tangential issue I had a look at the AquiferConfig's serializeOp() member function. That function will distribute all knowledge of numerical aquifers to all processes provided there are no changes to the numerical aquifer parts of AquiferConfig structure after serializeOp() has been called. That may of course still not be enough to get the information into the CpGrid on all ranks, but at least the information ought to be available everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants