Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differences in YODA files generated by YODA Tools versus the Excel Template #4

Open
11 tasks
horsburgh opened this issue Mar 17, 2016 · 1 comment
Open
11 tasks

Comments

@horsburgh
Copy link
Member

I have been comparing (as best I can) the files generated by @cdesyoun 's code and those that were generated directly from the Excel template. Here's some observed differences that could be fixed:

Testing using the YODA_TimeSeries_Example1_Template_0.3.1-alpha file:

  • In the YODA block, "YODAPy" should be enclosed in the quotation marks within the CreationTool element

  • Not sure this really matters, but the elements appear out of order in the files generated by YODA-Tools

  • Citations block is missing

  • AuthorLists block is missing

  • DataSetCitations block is missing

  • PrimaryPhone is missing from both the YODA file AND the Excel Template

  • The YODA File contains 4 spatial reference systems in the SpatialReferences block even though only one is actually used in the file

  • The ActionDescription in the Actions block should not be NULL. We need a description for the Action. The Excel template used "Generic observation action generated by Excel Template for TimeSeries"

  • In the CoumnDefinitions block, do the "Label" and "ODM2Field" element values need to be in quotations?

  • In the Data block you switch to using single quotes. I think you should consistently use double quotes.

  • In the Data block, if you add a space before the date/time and one after the last value it's a lot easier to split the table into columns in an Excel spreadsheet. This is unnecessary syntax-wise, but would make Anthony happy. So, it would look like this:

    [ "2010-06-03 11:15:00", -5, 1.0208, 1.022, 1.0232 ]

Other Observations that I think are better in the YODA Tools generated files:

  • In the SamplingFeature block, Elevation_m is enclosed in quotations in the YODA file generated from the Excel template and not in the one generated by YODA Tools. I'm assuming not enclosing it is the correct form for numeric data.
  • In the YODA-Tools version there is only one Action, whereas in the version generated by the Excel template there are three Actions. I believe it is more correct to use only 1 action for this file. This was a limitation of the Excel Template.
  • In the YODA-Tools version there is only one FeatureAction. This corresponds to the single Action, which is the desired behavior.
  • In the YODA-Tools version there is only one ActionBy record. This is consistent with the single Action record, but illustrates a deficiency in the Excel template in that only a single "Data Collector" can be affiliated with a data column. Not sure we need to do anything about this.
@cdesyoun
Copy link
Contributor

@horsburgh I think I fixed all of these issues that you pointed out. Please review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants