-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setting for sampling features to exclude from mapping #153
Comments
|
@lsetiawan yes using Redis sounds like a good idea, I was thinking about that a while back but haven't implemented anything yet. Did you have a javascript framework in mind? |
Just linking here to #150 To clarify, part of the issue is that maybe some sampling features should be excluded from the map (as @miguelcleon described when he opened the issue). It's not just about performance. There's map clutter as well, with potentially many specimen sampling features sharing the same lat-lon. But some specimens just don't make obvious sense to display on a map. On the email exchange, it was pointed out that if the sampling feature doesn't have lat-lon coordinates, it won't be loaded into the map; I assume that also means only sampling features that have a point geometry are actually queried for, so that these sampling features really don't have any impact at all? |
@emiliom Not quite. Everything is queried then filtered (https://github.com/miguelcleon/ODM2-Admin/blob/master/odm2admin/views.py#L640). I guess now that I think about this. We should just query for sampling features that have |
Or more specifically, FeatureGeometry is not null and SamplingFeatureGeoTypeCV == 'Point'. |
There is concern about loading a map with thousands of sampling features. This maybe too slow. To alleviate that we should add a MAP_CONFIG setting in the settings files to specify sampling feature types to exclude from the map.
The text was updated successfully, but these errors were encountered: